RESOLVED FIXED 76233
test-webkitpy: should support classes and individual test names as well as modules 
https://bugs.webkit.org/show_bug.cgi?id=76233
Summary test-webkitpy: should support classes and individual test names as well as mo...
Dirk Pranke
Reported 2012-01-12 17:19:12 PST
test-webkitpy: should support classes and individual test names as well as modules
Attachments
Patch (7.15 KB, patch)
2012-01-12 17:23 PST, Dirk Pranke 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-01-12 17:23:59 PST
Created attachment 122347 [details] Patch
Adam Barth
Comment 2 2012-01-13 13:02:14 PST
Comment on attachment 122347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review > Tools/Scripts/webkitpy/test/cat_unittest.py:-31 > - This blank line should stay according to PEP8 > Tools/Scripts/webkitpy/test/main.py:261 > + if os.path.exists(os.path.join(os.path.dirname(d), relpath)): I'm tempted to say we should go through filesystem here, but then again, that's probably not needed.
Dirk Pranke
Comment 3 2012-01-13 13:09:48 PST
(In reply to comment #2) > (From update of attachment 122347 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review > > > Tools/Scripts/webkitpy/test/cat_unittest.py:-31 > > - > > This blank line should stay according to PEP8 > Yeah, I'm not sure how that crept in. > > Tools/Scripts/webkitpy/test/main.py:261 > > + if os.path.exists(os.path.join(os.path.dirname(d), relpath)): > > I'm tempted to say we should go through filesystem here, but then again, that's probably not needed. I'm trying to avoid depending on anything (else) from webkitpy, but I suspect at some point I'll have to give just so I can write better tests.
Dirk Pranke
Comment 4 2012-01-13 13:16:50 PST
Committed r104977: <http://trac.webkit.org/changeset/104977>
Dirk Pranke
Comment 5 2012-01-13 13:24:09 PST
Committed r104980: <http://trac.webkit.org/changeset/104980>
Note You need to log in before you can comment on or make changes to this bug.