Bug 76233 - test-webkitpy: should support classes and individual test names as well as modules
Summary: test-webkitpy: should support classes and individual test names as well as mo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 76022
  Show dependency tree / graph
 
Reported: 2012-01-12 17:19 PST by Dirk Pranke
Modified: 2012-01-13 13:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.15 KB, patch)
2012-01-12 17:23 PST, Dirk Pranke 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-01-12 17:19:12 PST 
test-webkitpy: should support classes and individual test names as well as modules
Comment 1 Dirk Pranke 2012-01-12 17:23:59 PST 
Created attachment 122347 [details]
Patch
Comment 2 Adam Barth 2012-01-13 13:02:14 PST 
Comment on attachment 122347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review

> Tools/Scripts/webkitpy/test/cat_unittest.py:-31
> -

This blank line should stay according to PEP8

> Tools/Scripts/webkitpy/test/main.py:261
> +            if os.path.exists(os.path.join(os.path.dirname(d), relpath)):

I'm tempted to say we should go through filesystem here, but then again, that's probably not needed.
Comment 3 Dirk Pranke 2012-01-13 13:09:48 PST 
(In reply to comment #2)
> (From update of attachment 122347 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review
> 
> > Tools/Scripts/webkitpy/test/cat_unittest.py:-31
> > -
> 
> This blank line should stay according to PEP8
> 

Yeah, I'm not sure how that crept in.

> > Tools/Scripts/webkitpy/test/main.py:261
> > +            if os.path.exists(os.path.join(os.path.dirname(d), relpath)):
> 
> I'm tempted to say we should go through filesystem here, but then again, that's probably not needed.

I'm trying to avoid depending on anything (else) from webkitpy, but I suspect at some point I'll have to give just so I can write better tests.
Comment 4 Dirk Pranke 2012-01-13 13:16:50 PST 
Committed r104977: <http://trac.webkit.org/changeset/104977>
Comment 5 Dirk Pranke 2012-01-13 13:24:09 PST 
Committed r104980: <http://trac.webkit.org/changeset/104980>