Bug 76223 - Add mac-snowleopard pixel results for tests with scrollbars
Summary: Add mac-snowleopard pixel results for tests with scrollbars
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
Depends on:
Reported: 2012-01-12 16:29 PST by Emil A Eklund
Modified: 2012-01-12 20:35 PST (History)
3 users (show)

See Also:

Patch (640.17 KB, patch)
2012-01-12 17:30 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-01-12 16:29:33 PST
A bunch of our pixel tests fails on mac-snowleopard as the expected results are from lion where scrollbars are painted differently.
Comment 1 Emil A Eklund 2012-01-12 17:30:41 PST
Created attachment 122348 [details]
Comment 2 Eric Seidel (no email) 2012-01-12 18:58:07 PST
Comment on attachment 122348 [details]

We could also consider fixing the tests so that they either didn't have scrollbars (overflow: hidden) or were dumpAsText() tests.  But I'm definitely in favor of fewer tests failing.
Comment 3 Emil A Eklund 2012-01-12 19:05:01 PST
Sure, I'll look at changing some of these to not use visible scrollbars. I'd prefer landing this as is for now though as it'll help us identify the tests we are failing on the subpixelbranch but passing on trunk.

Thanks for the quick review.
Comment 4 Eric Seidel (no email) 2012-01-12 19:07:10 PST
Go for it!  I don't mean to get in the way of your greening of bots.  I'm happy to review these sorts of patches all day! :)
Comment 5 Emil A Eklund 2012-01-12 19:13:34 PST
Great, thank you!
Comment 6 WebKit Review Bot 2012-01-12 20:35:39 PST
Comment on attachment 122348 [details]

Clearing flags on attachment: 122348

Committed r104894: <http://trac.webkit.org/changeset/104894>
Comment 7 WebKit Review Bot 2012-01-12 20:35:45 PST
All reviewed patches have been landed.  Closing bug.