WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76221
NRWT should categorize options in --help
https://bugs.webkit.org/show_bug.cgi?id=76221
Summary
NRWT should categorize options in --help
Tim Horton
Reported
2012-01-12 15:46:13 PST
I keep getting lost in the wall of text that is new-run-webkit-tests --help. optparse has option groups, and our options are already grouped into reasonable groups! I have a patch.
Attachments
patch
(6.31 KB, patch)
2012-01-12 15:48 PST
,
Tim Horton
eric
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2012-01-12 15:48:40 PST
Created
attachment 122327
[details]
patch
WebKit Review Bot
Comment 2
2012-01-12 15:52:31 PST
Attachment 122327
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:157: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3
2012-02-10 10:32:38 PST
Ha! See
bug 37836
.
Eric Seidel (no email)
Comment 4
2012-02-10 10:33:57 PST
My (ancient) fix was more about cleaning up the code than the display. I agree we should clean up the display.
Eric Seidel (no email)
Comment 5
2012-02-10 10:34:26 PST
We also can remove/hide many of these options.
WebKit Review Bot
Comment 6
2012-02-10 10:41:27 PST
Comment on
attachment 122327
[details]
patch Rejecting
attachment 122327
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 198 (offset 44 lines). Hunk #2 FAILED at 175. Hunk #3 succeeded at 269 (offset 43 lines). Hunk #4 succeeded at 286 (offset 43 lines). Hunk #5 FAILED at 307. Hunk #6 FAILED at 381. Hunk #7 succeeded at 454 (offset 51 lines). 3 out of 7 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/11480744
Tim Horton
Comment 7
2012-02-10 10:42:27 PST
(In reply to
comment #6
)
> (From update of
attachment 122327
[details]
) > Rejecting
attachment 122327
[details]
from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > 198 (offset 44 lines). > Hunk #2 FAILED at 175. > Hunk #3 succeeded at 269 (offset 43 lines). > Hunk #4 succeeded at 286 (offset 43 lines). > Hunk #5 FAILED at 307. > Hunk #6 FAILED at 381. > Hunk #7 succeeded at 454 (offset 51 lines). > 3 out of 7 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output:
http://queues.webkit.org/results/11480744
I didn't really expect that to still apply after a month; I'll commit it manually.
Tim Horton
Comment 8
2012-02-10 10:51:16 PST
Landed in
http://trac.webkit.org/changeset/107415
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug