Bug 76218 - [chromium] event.dataTransfer.types should not return "Text" or "URL"
Summary: [chromium] event.dataTransfer.types should not return "Text" or "URL"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on: 76925
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-12 15:02 PST by Daniel Cheng
Modified: 2012-01-24 17:18 PST (History)
2 users (show)

See Also:


Attachments
Patch (10.01 KB, patch)
2012-01-24 15:02 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (12.97 KB, patch)
2012-01-24 15:21 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2012-01-12 15:02:37 PST
In crbug.com/76622, we fixed it so we wouldn't return "Text" or "URL" in the types attribute in pastes. We still return in real code though because the ChromiumDataObject implementation was never updated.
Comment 1 Daniel Cheng 2012-01-24 15:02:41 PST
Created attachment 123819 [details]
Patch
Comment 2 Tony Chang 2012-01-24 15:13:45 PST
Comment on attachment 123819 [details]
Patch

Would be nice to get an ews run.  Also, you may need to add the new test to all the relevant Skipped files.  Yael, do you know why all the dropzone tests are disabled on the qt bots?
Comment 3 Daniel Cheng 2012-01-24 15:21:00 PST
Created attachment 123824 [details]
Patch
Comment 4 Daniel Cheng 2012-01-24 15:48:31 PST
Comment on attachment 123824 [details]
Patch

Clearing flags on attachment: 123824

Committed r105826: <http://trac.webkit.org/changeset/105826>
Comment 5 Daniel Cheng 2012-01-24 15:48:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Yael 2012-01-24 17:18:53 PST
(In reply to comment #2)
> (From update of attachment 123819 [details])
> Would be nice to get an ews run.  Also, you may need to add the new test to all the relevant Skipped files.  Yael, do you know why all the dropzone tests are disabled on the qt bots?
Qt does not have test infrastructure for drag&drop.