Bug 76203 - [chromium] Fix DC leak in WebScreenInfoFactory.
Summary: [chromium] Fix DC leak in WebScreenInfoFactory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 76135
  Show dependency tree / graph
 
Reported: 2012-01-12 12:46 PST by David Levin
Modified: 2012-01-12 15:34 PST (History)
0 users

See Also:

Attachments
Patch (7.20 KB, patch)
2012-01-12 14:55 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2012-01-12 15:10 PST, David Levin 		dimich: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2012-01-12 12:46:13 PST 
See summary.
Comment 1 David Levin 2012-01-12 14:55:15 PST 
Created attachment 122315 [details]
Patch
Comment 2 Dmitry Titov 2012-01-12 15:05:55 PST 
Comment on attachment 122315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122315&action=review

Chromium will live! One note:

> Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:176
> +            ['include', 'win/OwnPtrWin\\.cpp$'],

Could we only have changes directly related to the DC fix? It would be easier to understand the patch.

> Source/JavaScriptCore/wtf/OwnPtrCommon.h:31
> +#if OS(WIN)

Same as above.
Comment 3 David Levin 2012-01-12 15:10:31 PST 
Created attachment 122317 [details]
Patch
Comment 4 David Levin 2012-01-12 15:34:55 PST 
Committed as http://trac.webkit.org/changeset/104867