Bug 76196 - Move snapRubberBandTimerFired to ScrollElasticityController
Summary: Move snapRubberBandTimerFired to ScrollElasticityController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 11:57 PST by Anders Carlsson
Modified: 2012-01-12 12:04 PST (History)
0 users

See Also:


Attachments
Patch (11.86 KB, patch)
2012-01-12 11:57 PST, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-01-12 11:57:22 PST
Move snapRubberBandTimerFired to ScrollElasticityController
Comment 1 Anders Carlsson 2012-01-12 11:57:52 PST
Created attachment 122279 [details]
Patch
Comment 2 Andreas Kling 2012-01-12 12:02:12 PST
Comment on attachment 122279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122279&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

OOPS!

> Source/WebCore/platform/mac/ScrollElasticityController.mm:95
> +    if (!m_momentumScrollInProgress || m_ignoreMomentumScrolls) {

We could reverse this condition and do an early return to reduce nesting.
Comment 3 Anders Carlsson 2012-01-12 12:04:40 PST
Committed r104842: <http://trac.webkit.org/changeset/104842>