RESOLVED FIXED Bug 76190
[Qt] [PATCH] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box. 
https://bugs.webkit.org/show_bug.cgi?id=76190
Summary [Qt] [PATCH] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.
Johannes Obermayr
Reported 2012-01-12 10:10:10 PST
Created attachment 122267 [details] Patch Please use 'git am 0001-Use-Ok-and-Cancel-buttons-in-JavaScript-confirm-box.patch' to keep author information ... Maybe you should create a qtwebkit-patches mailing list for a quick and comfortable sending patches via 'git send-email' ... See: http://www.javascripter.net/faq/confirm.htm Fixes: https://bugs.kde.org/show_bug.cgi?id=287629
Attachments
Patch (1.81 KB, patch)
2012-01-12 10:10 PST, Johannes Obermayr 		noam: review-
noam: commit-queue-
DetailsFormatted DiffDiff
new patch (2.08 KB, patch)
2012-05-30 08:10 PDT, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Færøy
Comment 1 2012-01-12 13:00:41 PST
(In reply to comment #0) > Please use 'git am 0001-Use-Ok-and-Cancel-buttons-in-JavaScript-confirm-box.patch' to keep author information ... The WebKit project doesn't work like that since the official repository is a subversion repository even though most of the QtWebKit developers uses the Git trees since we can actively work on QtWebKit without ever having to "git push" or "svn commit" because we have tons of automated review and commit tools :-) Please have a look at http://trac.webkit.org/wiki/QtWebKitContrib and http://www.webkit.org/coding/contributing.html and upload a version of your patch that contains a proper ChangeLog entry :-) > Maybe you should create a qtwebkit-patches mailing list for a quick and comfortable sending patches via 'git send-email' ... Wont work since all patches must be reviewed of an approved WebKit reviewer and the reviewer tool is built into our Bugzilla setup :-)
Johannes Obermayr
Comment 2 2012-01-12 13:05:46 PST
Sorry for wasting your time ...
Alexander Færøy
Comment 3 2012-01-12 13:07:19 PST
(In reply to comment #2) > Sorry for wasting your time ... You are not wasting our time. The patch looks clean enough for me, but I am not a reviewer. If you resubmit it with a proper ChangeLog entry, I will CC some reviewers who can review your changes :-)
Johannes Obermayr
Comment 4 2012-01-12 13:14:34 PST
With such stupid rules I regret of spending a few hours to detect the issue :-( Fix it yourself ...
Noam Rosenthal
Comment 5 2012-01-12 16:24:26 PST
Comment on attachment 122267 [details] Patch Patch does not include changelog.
Simon Hausmann
Comment 6 2012-01-13 01:19:05 PST
(In reply to comment #4) > With such stupid rules I regret of spending a few hours to detect the issue :-( I'm sorry Johannes that you feel that way, but this is just like in KDE or any other open source project: There are rules about contributing source code. In KDE you have to understand SVN, write a descriptive commit message and adhere to BUG:12344 etc. standards for the bugzilla integration. Then you need to get yourself access to the KDE SVN repository or find a kind soul to review & commit the patch for you. In the Git project you need to use git send-email to send your patch to the git list, CC Junio and make sure your commit has the right Signed-off-by. In Qt you have to upload your patch to Gerrit and it needs to have a unique Change-Id, generated by a git commit hook. And lastly in WebKit you upload your patch to Bugzilla together with a ChangeLog entry. The documentation at http://www.webkit.org/coding/contributing.html explains the necessary steps and the tools available make it easy to "play by the rules". But as you can see, every project has such rules. If you do not want to play by those rules but still get your change contributed, then you need to approach a fellow developer with kind words asking him to do the "paperwork" on your behalf. In WebKit's case however you still need to do the initial patch upload to accept the contribution licensing agreement, but it is possible to get help for getting your patch reviewed and landed manually. I'm re-opening this bug because the issue you discovered still appears to be valid, regardless of your feelings towards the patch contribution process of WebKit.
Zoltan Arvai
Comment 8 2012-05-30 08:10:12 PDT
Created attachment 144821 [details] new patch Patch with changelog.
Csaba Osztrogonác
Comment 9 2012-05-30 08:27:50 PDT
Reopen to let EWS bots test the patch
WebKit Review Bot
Comment 10 2012-06-02 00:13:00 PDT
Comment on attachment 144821 [details] new patch Clearing flags on attachment: 144821 Committed r119315: <http://trac.webkit.org/changeset/119315>
WebKit Review Bot
Comment 11 2012-06-02 00:13:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.