WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76187
Add a check-webkit-style exception for GDBInterface.cpp
https://bugs.webkit.org/show_bug.cgi?id=76187
Summary
Add a check-webkit-style exception for GDBInterface.cpp
Sanjoy Das
Reported
2012-01-12 09:27:11 PST
This so that
https://bugs.webkit.org/show_bug.cgi?id=75387
can be merged without style errors.
Attachments
Add a check-webkit-style exception for GDBInterface.cpp
(1.84 KB, patch)
2012-01-12 09:30 PST
,
Sanjoy Das
levin
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Proposed patch
(1.86 KB, patch)
2012-01-14 03:13 PST
,
Sanjoy Das
pnormand
: review-
Details
Formatted Diff
Diff
Add a check-webkit-style exception for GDBInterface.cpp
(3.01 KB, patch)
2012-01-17 14:24 PST
,
Sanjoy Das
no flags
Details
Formatted Diff
Diff
Add a check-webkit-style exception for GDBInterface.cpp
(3.01 KB, patch)
2012-01-17 15:55 PST
,
Sanjoy Das
no flags
Details
Formatted Diff
Diff
Add a check-webkit-style exception for GDBInterface.cpp
(3.14 KB, patch)
2012-01-17 16:22 PST
,
Sanjoy Das
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Sanjoy Das
Comment 1
2012-01-12 09:30:53 PST
Created
attachment 122258
[details]
Add a check-webkit-style exception for GDBInterface.cpp
WebKit Review Bot
Comment 2
2012-01-12 12:16:17 PST
Comment on
attachment 122258
[details]
Add a check-webkit-style exception for GDBInterface.cpp Rejecting
attachment 122258
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/11209140
Sanjoy Das
Comment 3
2012-01-14 03:13:53 PST
Created
attachment 122539
[details]
Proposed patch
Philippe Normand
Comment 4
2012-01-14 03:35:55 PST
Comment on
attachment 122539
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=122539&action=review
It is looking good! The last missing bit is a little unittest in Tools/Scripts/webkitpy/style/checker_unittest.py maybe you can add it in test_path_rules_specifier. To run the tests use test-webkitpy.
> Tools/ChangeLog:7 > + Unreviewed
The Reviewed by NOBODY (OOPS!). line should remain. It is transformed to "Reviewed by Foo" by the commiter or the commit-queue bot.
Sanjoy Das
Comment 5
2012-01-17 14:24:06 PST
Created
attachment 122812
[details]
Add a check-webkit-style exception for GDBInterface.cpp + a test case for the style checker.
WebKit Review Bot
Comment 6
2012-01-17 14:26:47 PST
Attachment 122812
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/style/checker_unittest.py:263: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sanjoy Das
Comment 7
2012-01-17 15:55:55 PST
Created
attachment 122832
[details]
Add a check-webkit-style exception for GDBInterface.cpp
Martin Robinson
Comment 8
2012-01-17 16:03:53 PST
Comment on
attachment 122832
[details]
Add a check-webkit-style exception for GDBInterface.cpp View in context:
https://bugs.webkit.org/attachment.cgi?id=122832&action=review
This looks just fine to me, though there are a couple relaly minor style nits.
> Tools/ChangeLog:4 > + Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so > + that it does not fail the style check.
Typically this is the bug title itself and the description oes below the "Reviewed by" line.
> Tools/Scripts/webkitpy/style/checker.py:230 > + # and __jit_debug_descriptor when integrating with gdb
Missing a period here.
> Tools/Scripts/webkitpy/style/checker_unittest.py:264 > + # Test if the exception for GDBInterface.cpp is in place
Here as well.
Sanjoy Das
Comment 9
2012-01-17 16:22:59 PST
Created
attachment 122835
[details]
Add a check-webkit-style exception for GDBInterface.cpp This patch should fix the style errors.
WebKit Review Bot
Comment 10
2012-01-17 19:19:24 PST
Comment on
attachment 122835
[details]
Add a check-webkit-style exception for GDBInterface.cpp Clearing flags on attachment: 122835 Committed
r105232
: <
http://trac.webkit.org/changeset/105232
>
WebKit Review Bot
Comment 11
2012-01-17 19:19:29 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug