Bug 76183 – Web Inspector: make HTML editing preserve node identity when node nesting level changes.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

As of today, editing

<p>Foo</p>

to become

<div><p>Foo</p></div>

re-creates <p>Foo</p>, hence all JavaScript wrappers pointing to <p> become invalid.

It should move it into the new <div> instead, while preserving the node identity and wrapper references.

[Pavel Feldman]

Created attachment 122253 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 122253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122253&action=review

> Source/WebCore/inspector/DOMEditor.cpp:402
> +    Deque<Digest*> queue;

Why do you prefer BFS over DFS here?

[Pavel Feldman]

Committed r104920: <http://trac.webkit.org/changeset/104920>

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed r104920: <http://trac.webkit.org/changeset/104920>

Reopen, because it broke the 32 bit builds:
cc1plus: warnings being treated as errors
/ramdisk/qt-linux-32-release-webkit2/build/Source/WebCore/inspector/DOMEditor.cpp: In member function ‘void WebCore::DOMEditor::dumpMap(const WTF::String&, const WTF::Vector<std::pair<WebCore::DOMEditor::Digest*, unsigned int>, 0u>&, const WTF::Vector<WTF::OwnPtr<WebCore::DOMEditor::Digest>, 0u>&)’:
/ramdisk/qt-linux-32-release-webkit2/build/Source/WebCore/inspector/DOMEditor.cpp:430: error: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘size_t’
/ramdisk/qt-linux-32-release-webkit2/build/Source/WebCore/inspector/DOMEditor.cpp:430: error: format ‘%ld’ expects type ‘long int’, but argument 6 has type ‘unsigned int’

Could you fix it?

[Csaba Osztrogonác]

Buildfix landed in http://trac.webkit.org/changeset/104923

[Antonio Gomes]

(In reply to comment #5)
> Buildfix landed in http://trac.webkit.org/changeset/104923

can be re-closed?