You need to
before you can comment on or make changes to this bug.
Created an attachment (id=122236) [details]
(From update of attachment 122236 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=122236&action=review
> +void QtWebPageEventHandler::inputPanelVisibleChanged()
> + if (!m_interactionEngine || !qApp->inputPanel()->visible())
> + return;
> + const EditorState& editor = m_webPageProxy->editorState();
> + m_interactionEngine->focusEditableArea(QRectF(editor.cursorRect), QRectF(editor.editorRect));
You're unconditionally connecting to the inputPanel's signal. Shouldn't the focusEditableArea call only be done if we have the focus? Perhaps we should also only connect when we receive focus and disconnect when we loose it?
You are rigth, I will fix that!
Created an attachment (id=122399) [details]
Created an attachment (id=122408) [details]
Landed in 105275