RESOLVED FIXED76174
[Qt] Zoom in to the focused node only when vkb starts becoming visible 
https://bugs.webkit.org/show_bug.cgi?id=76174
Summary [Qt] Zoom in to the focused node only when vkb starts becoming visible
Kenneth Rohde Christiansen
Reported 2012-01-12 07:06:59 PST
SSIA
Attachments
Patch (9.58 KB, patch)
2012-01-12 07:08 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (9.61 KB, patch)
2012-01-13 02:15 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (10.65 KB, patch)
2012-01-13 04:11 PST, Kenneth Rohde Christiansen 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-01-12 07:08:28 PST
Created attachment 122236 [details] Patch
Simon Hausmann
Comment 2 2012-01-12 07:12:42 PST
Comment on attachment 122236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122236&action=review > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:442 > +void QtWebPageEventHandler::inputPanelVisibleChanged() > +{ > + if (!m_interactionEngine || !qApp->inputPanel()->visible()) > + return; > + > + const EditorState& editor = m_webPageProxy->editorState(); > + m_interactionEngine->focusEditableArea(QRectF(editor.cursorRect), QRectF(editor.editorRect)); You're unconditionally connecting to the inputPanel's signal. Shouldn't the focusEditableArea call only be done if we have the focus? Perhaps we should also only connect when we receive focus and disconnect when we loose it?
Kenneth Rohde Christiansen
Comment 3 2012-01-12 07:13:38 PST
You are rigth, I will fix that!
Kenneth Rohde Christiansen
Comment 4 2012-01-13 02:15:14 PST
Created attachment 122399 [details] Patch
Kenneth Rohde Christiansen
Comment 5 2012-01-13 04:11:31 PST
Created attachment 122408 [details] Patch
Kenneth Rohde Christiansen
Comment 6 2012-01-18 07:37:49 PST
Landed in 105275
Note You need to log in before you can comment on or make changes to this bug.