Bug 76155 - Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia
Summary: Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 01:19 PST by Kenichi Ishibashi
Modified: 2012-01-12 21:50 PST (History)
8 users (show)

See Also:


Attachments
Patch (21.53 KB, patch)
2012-01-12 01:23 PST, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff
Patch (22.44 KB, patch)
2012-01-12 15:43 PST, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-01-12 01:19:54 PST
SimpleFontDataSkia.cpp doesn't contain Harfbuzz specific code so it should be located in Source/WebCore/platform/graphics/skia.
Comment 1 Kenichi Ishibashi 2012-01-12 01:23:29 PST
Created attachment 122187 [details]
Patch
Comment 2 Tony Chang 2012-01-12 10:11:45 PST
Comment on attachment 122187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review

> Source/WebCore/WebCore.gyp/WebCore.gyp:1710
> -            ['include', 'platform/graphics/harfbuzz/SimpleFontDataSkia\\.cpp$'],
> +            ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'],

I think you also need to exclude the file on mac and win.  The mac code is around line 1661 and the win code is around line 1692.
Comment 3 Kenichi Ishibashi 2012-01-12 15:43:37 PST
Created attachment 122324 [details]
Patch
Comment 4 Kenichi Ishibashi 2012-01-12 15:44:20 PST
Comment on attachment 122187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review

Thank you for review!

>> Source/WebCore/WebCore.gyp/WebCore.gyp:1710
>> +            ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'],
> 
> I think you also need to exclude the file on mac and win.  The mac code is around line 1661 and the win code is around line 1692.

Done.
Comment 5 Tony Chang 2012-01-12 16:02:09 PST
Comment on attachment 122324 [details]
Patch

Please watch the chromium bots when you land.  Thanks!
Comment 6 Kenichi Ishibashi 2012-01-12 16:10:53 PST
(In reply to comment #5)
> (From update of attachment 122324 [details])
> Please watch the chromium bots when you land.  Thanks!

I see. Thanks!
Comment 7 WebKit Review Bot 2012-01-12 16:28:06 PST
Comment on attachment 122324 [details]
Patch

Clearing flags on attachment: 122324

Committed r104876: <http://trac.webkit.org/changeset/104876>
Comment 8 WebKit Review Bot 2012-01-12 16:28:11 PST
All reviewed patches have been landed.  Closing bug.