Bug 76149 - [chromium] Turn off FrameRateController timesource when it is not needed
Summary: [chromium] Turn off FrameRateController timesource when it is not needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
: 75560 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-11 23:20 PST by Nat Duca
Modified: 2012-02-01 07:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (20.28 KB, patch)
2012-01-11 23:21 PST, Nat Duca
no flags Details | Formatted Diff | Diff
Without the fail (20.29 KB, patch)
2012-01-12 02:00 PST, Nat Duca
no flags Details | Formatted Diff | Diff
Patch for landing (19.76 KB, patch)
2012-01-12 11:07 PST, Nat Duca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2012-01-11 23:20:38 PST
[chromium] Turn off FrameRateController timesource when it is not needed
Comment 1 Nat Duca 2012-01-11 23:21:10 PST
Created attachment 122174 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-11 23:41:59 PST
Comment on attachment 122174 [details]
Patch

Attachment 122174 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11170705
Comment 3 Nat Duca 2012-01-12 02:00:40 PST
Created attachment 122191 [details]
Without the fail
Comment 4 James Robinson 2012-01-12 10:11:28 PST
Comment on attachment 122191 [details]
Without the fail

View in context: https://bugs.webkit.org/attachment.cgi?id=122191&action=review

R=me except the CCLayerTreeHostTest change, which I'm hoping is inadvertent.

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:227
> +        //        m_timedOut = true;
> +        //        endTest();

what happened here?
Comment 5 Nat Duca 2012-01-12 10:54:19 PST
(In reply to comment #4)
> > > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:227
> > +        //        m_timedOut = true;
> > +        //        endTest();
> 
> what happened here?

Oops. Overtired.

Although, I should really try sneaking in "disable the entire test harness" edits like this more often, keep people on their toes. ;)
Comment 6 Nat Duca 2012-01-12 11:07:42 PST
Created attachment 122274 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-01-12 12:15:03 PST
Comment on attachment 122274 [details]
Patch for landing

Clearing flags on attachment: 122274

Committed r104844: <http://trac.webkit.org/changeset/104844>
Comment 8 WebKit Review Bot 2012-01-12 12:15:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Nat Duca 2012-02-01 07:15:09 PST
*** Bug 75560 has been marked as a duplicate of this bug. ***