JSExportMacros.h is hidden from Chromium port by the USE(JSC) gaurd. But WebCore uses Yarr which is a part of JSC and it includes JSExportMacros.h indirectly. So Chromium should be able to see it.
Created attachment 122171 [details] Patch
Ah, Yarr. /me hopes Tony will review this patch.
(In reply to comment #2) > Ah, Yarr. /me hopes Tony will review this patch. OK, thanks for taking a look!
Comment on attachment 122171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122171&action=review > Source/JavaScriptCore/config.h:37 > +// Chromium doesn't have runtime/ in its include paths. > +#include "runtime/JSExportMacros.h" Should we add runtime/ to the include path for yarr? Actually, it looks like it's already there for the yarr target. Should we add it to direct_dependent_settings?
(In reply to comment #4) > (From update of attachment 122171 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122171&action=review > > > Source/JavaScriptCore/config.h:37 > > +// Chromium doesn't have runtime/ in its include paths. > > +#include "runtime/JSExportMacros.h" > > Should we add runtime/ to the include path for yarr? Actually, it looks like it's already there for the yarr Whoa, I didn't know about direct_dependent_settings. I'll try it.
> > Should we add runtime/ to the include path for yarr? Actually, it looks like it's already there for the yarr Whoa, I didn't know about direct_dependent_settings. I'll try it. I just tried direct_dependent_settings but noticed that JavaScriptCore/config.h is included from not only direct_dependent but also some more (like Webkit APi layer). Including runtime/ everywhere looks a bit too much polluting for me so I'll land this as is. Anyway, thanks for pointing it out. I hope I could find some cleaner way for this.
Comment on attachment 122171 [details] Patch Clearing flags on attachment: 122171 Committed r104897: <http://trac.webkit.org/changeset/104897>
All reviewed patches have been landed. Closing bug.