getComputedStyle margin percentage test for CSS calc
Created attachment 122134 [details] Patch
Created attachment 122170 [details] Patch
Comment on attachment 122134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122134&action=review > LayoutTests/css3/calc/getComputedStyle-margin-percentage.html:36 > + shouldEvaluateTo("window.getComputedStyle(document.getElementById('calc', null)).getPropertyValue('" + prop + "')", "window.getComputedStyle(document.getElementById('control', null)).getPropertyValue('" + prop + "')"); No need for the "window" prefixes here. What is the "null" second argument to getElementById for? I think you mean that to be a second argument for getComputedStyle.
Comment on attachment 122134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122134&action=review >> LayoutTests/css3/calc/getComputedStyle-margin-percentage.html:36 >> + shouldEvaluateTo("window.getComputedStyle(document.getElementById('calc', null)).getPropertyValue('" + prop + "')", "window.getComputedStyle(document.getElementById('control', null)).getPropertyValue('" + prop + "')"); > > No need for the "window" prefixes here. What is the "null" second argument to getElementById for? I think you mean that to be a second argument for getComputedStyle. Thanks for the review Darin. You're right about the null - it was a mistake. I've fixed it, and removed the 'window' prefix as well.
Created attachment 122614 [details] Patch
Comment on attachment 122614 [details] Patch Clearing flags on attachment: 122614 Committed r105647: <http://trac.webkit.org/changeset/105647>
All reviewed patches have been landed. Closing bug.