Bug 76130 - getComputedStyle margin percentage test for CSS calc
Summary: getComputedStyle margin percentage test for CSS calc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Lawther
URL:
Keywords:
Depends on:
Blocks: 16662
  Show dependency tree / graph
 
Reported: 2012-01-11 17:07 PST by Mike Lawther
Modified: 2012-01-23 15:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2012-01-11 17:10 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch (3.35 KB, patch)
2012-01-11 22:16 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch (3.31 KB, patch)
2012-01-16 04:15 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2012-01-11 17:07:27 PST 
getComputedStyle margin percentage test for CSS calc
Comment 1 Mike Lawther 2012-01-11 17:10:04 PST 
Created attachment 122134 [details]
Patch
Comment 2 Mike Lawther 2012-01-11 22:16:16 PST 
Created attachment 122170 [details]
Patch
Comment 3 Darin Adler 2012-01-13 14:40:03 PST 
Comment on attachment 122134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122134&action=review

> LayoutTests/css3/calc/getComputedStyle-margin-percentage.html:36
> +        shouldEvaluateTo("window.getComputedStyle(document.getElementById('calc', null)).getPropertyValue('" + prop + "')", "window.getComputedStyle(document.getElementById('control', null)).getPropertyValue('" + prop + "')");

No need for the "window" prefixes here. What is the "null" second argument to getElementById for? I think you mean that to be a second argument for getComputedStyle.
Comment 4 Mike Lawther 2012-01-16 04:14:37 PST 
Comment on attachment 122134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122134&action=review

>> LayoutTests/css3/calc/getComputedStyle-margin-percentage.html:36
>> +        shouldEvaluateTo("window.getComputedStyle(document.getElementById('calc', null)).getPropertyValue('" + prop + "')", "window.getComputedStyle(document.getElementById('control', null)).getPropertyValue('" + prop + "')");
> 
> No need for the "window" prefixes here. What is the "null" second argument to getElementById for? I think you mean that to be a second argument for getComputedStyle.

Thanks for the review Darin. You're right about the null - it was a mistake. I've fixed it, and removed the 'window' prefix as well.
Comment 5 Mike Lawther 2012-01-16 04:15:43 PST 
Created attachment 122614 [details]
Patch
Comment 6 WebKit Review Bot 2012-01-23 15:32:55 PST 
Comment on attachment 122614 [details]
Patch

Clearing flags on attachment: 122614

Committed r105647: <http://trac.webkit.org/changeset/105647>
Comment 7 WebKit Review Bot 2012-01-23 15:32:59 PST 
All reviewed patches have been landed.  Closing bug.