Bug 76117 - Code duplication for invoking the JIT and DFG should be reduced
Summary: Code duplication for invoking the JIT and DFG should be reduced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-01-11 16:26 PST by Filip Pizlo
Modified: 2012-01-11 17:24 PST (History)
0 users

See Also:


Attachments
the patch (15.11 KB, patch)
2012-01-11 16:31 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-01-11 16:26:51 PST
The harness for doing JIT compilation for program and eval code is identical modulo which CodeBlock it references, and the harness for doing JIT compilation of function for call and function for construct is identical modulo which code block, jitCode, and jitCodeWithArityCheck it references.
Comment 1 Filip Pizlo 2012-01-11 16:27:18 PST
<rdar://problem/10680189>
Comment 2 Filip Pizlo 2012-01-11 16:31:53 PST
Created attachment 122125 [details]
the patch
Comment 3 Geoffrey Garen 2012-01-11 16:34:11 PST
Comment on attachment 122125 [details]
the patch

rs=me
Comment 4 Filip Pizlo 2012-01-11 17:24:38 PST
Landed in http://trac.webkit.org/changeset/104774