RESOLVED FIXED 76109
last-green-revision should report the revision that succeeded on all bots 
https://bugs.webkit.org/show_bug.cgi?id=76109
Summary last-green-revision should report the revision that succeeded on all bots
Ryosuke Niwa
Reported 2012-01-11 15:09:31 PST
This is continuation of the bug 76011. last-green-revision should be able to tell us the last known green revision among the bots that match the given regex if there is any.
Attachments
Adds the feature (15.51 KB, patch)
2012-01-11 15:17 PST, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-01-11 15:17:33 PST
Created attachment 122107 [details] Adds the feature
Ryosuke Niwa
Comment 2 2012-01-11 15:18:09 PST
With this patch, sheriffbot can tell us the last known green revision as in: rniwa-macpro:webkit4 rniwa$ Tools/Scripts/webkit-patch last-green-revision Qt The last known green revision is 104740 Qt Linux Release: 104744 Qt Linux Release minimal: 104749 Qt Linux ARMv7 Release: 104749 Qt Windows 32-bit Release: 104749 Qt Windows 32-bit Debug: 104749 Qt SnowLeopard Release: 104740 Qt Linux MIPS Release: 104748 Qt Linux SH4 Release: 104748
Ryosuke Niwa
Comment 3 2012-01-11 15:18:48 PST
When there is no such a revision, it'll still give us the last known green revision per bot as in: rniwa-macpro:webkit4 rniwa$ Tools/Scripts/webkit-patch last-green-revision Chromium Chromium Win Release: 104748 Chromium Win Release (Tests) has had no green revision in the last 100 runs Chromium Mac Release: 104747 Chromium Mac Release (Tests): 104744 Chromium Linux Release: 104749 Chromium Linux Release (Tests): 104746 Chromium Linux Release (Grid Layout): 104746 Chromium Android Release: 104649
Adam Barth
Comment 4 2012-01-11 15:21:06 PST
Comment on attachment 122107 [details] Adds the feature View in context: https://bugs.webkit.org/attachment.cgi?id=122107&action=review > Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:462 > + # Once we found X, check if remaining builders succeeded in the neiborhood of X. typo: neiborhood
Ryosuke Niwa
Comment 5 2012-01-11 15:45:09 PST
Thanks for the review! (In reply to comment #4) > (From update of attachment 122107 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122107&action=review > > > Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:462 > > + # Once we found X, check if remaining builders succeeded in the neiborhood of X. > > typo: neiborhood Oops, will fix.
Ryosuke Niwa
Comment 6 2012-01-11 15:46:57 PST
Committed r104754: <http://trac.webkit.org/changeset/104754>
Note You need to log in before you can comment on or make changes to this bug.