RESOLVED FIXED 76099
test-webkitpy: fix -v and eliminate some spurious warnings 
https://bugs.webkit.org/show_bug.cgi?id=76099
Summary test-webkitpy: fix -v and eliminate some spurious warnings
Dirk Pranke
Reported 2012-01-11 13:26:57 PST
test-webkitpy: fix -v and eliminate some spurious warnings
Attachments
Patch (6.33 KB, patch)
2012-01-11 13:30 PST, Dirk Pranke 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-01-11 13:30:27 PST
Created attachment 122083 [details] Patch
Dirk Pranke
Comment 2 2012-01-11 13:32:48 PST
Comment on attachment 122083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122083&action=review > Tools/Scripts/webkitpy/test/main.py:119 > + test_runner = unittest.TextTestRunner Yes, unittest.main() is actually this stupid and needs a class passed in for -v to work.
Dirk Pranke
Comment 3 2012-01-11 13:42:32 PST
Committed r104740: <http://trac.webkit.org/changeset/104740>
Eric Seidel (no email)
Comment 4 2012-01-11 13:58:09 PST
Comment on attachment 122083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122083&action=review OK. > Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:47 > + self._handle_style_error(self.line_number_from_json_exception(e), 'json/syntax', 5, str(e)) unicode? > Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:51 > + match = re.search(r': line (?P<line>\d+) column \d+', str(error)) unicode?
Note You need to log in before you can comment on or make changes to this bug.