Bug 76099 - test-webkitpy: fix -v and eliminate some spurious warnings
Summary: test-webkitpy: fix -v and eliminate some spurious warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 13:26 PST by Dirk Pranke
Modified: 2012-01-11 13:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.33 KB, patch)
2012-01-11 13:30 PST, Dirk Pranke
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-01-11 13:26:57 PST
test-webkitpy: fix -v and eliminate some spurious warnings
Comment 1 Dirk Pranke 2012-01-11 13:30:27 PST
Created attachment 122083 [details]
Patch
Comment 2 Dirk Pranke 2012-01-11 13:32:48 PST
Comment on attachment 122083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122083&action=review

> Tools/Scripts/webkitpy/test/main.py:119
> +            test_runner = unittest.TextTestRunner

Yes, unittest.main() is actually this stupid and needs a class passed in for -v to work.
Comment 3 Dirk Pranke 2012-01-11 13:42:32 PST
Committed r104740: <http://trac.webkit.org/changeset/104740>
Comment 4 Eric Seidel (no email) 2012-01-11 13:58:09 PST
Comment on attachment 122083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122083&action=review

OK.

> Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:47
> +            self._handle_style_error(self.line_number_from_json_exception(e), 'json/syntax', 5, str(e))

unicode?

> Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:51
> +        match = re.search(r': line (?P<line>\d+) column \d+', str(error))

unicode?