RESOLVED FIXED Bug 76086
Be more aggressive about deleting unnecessary results from the test-results-server json files 
https://bugs.webkit.org/show_bug.cgi?id=76086
Summary Be more aggressive about deleting unnecessary results from the test-results-s...
Ojan Vafai
Reported 2012-01-11 11:48:55 PST
Be more aggressive about deleting unnecessary results from the test-results-server json files
Attachments
Patch (7.02 KB, patch)
2012-01-11 11:49 PST, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-01-11 11:49:50 PST
Created attachment 122061 [details] Patch
Tony Chang
Comment 2 2012-01-11 11:58:04 PST
Comment on attachment 122061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122061&action=review > Tools/TestResultServer/model/jsonresults.py:212 > + deletable_types = set([JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA, JSON_RESULTS_SKIP]) Nit: tuple instead of list: set((JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA, JSON_RESULTS_SKIP)) > Tools/TestResultServer/model/jsonresults.py:214 > + for result in aggregated_test[JSON_RESULTS_RESULTS]: > + if result[1] not in deletable_types: Not sure if it's any better, but this could be: if any((1 for result in aggregated_test[JSON_RESULTS_RESULTS] if result[1] not in deletable_types)):
Ojan Vafai
Comment 3 2012-01-11 12:01:37 PST
Committed r104731: <http://trac.webkit.org/changeset/104731>
Note You need to log in before you can comment on or make changes to this bug.