Bug 76086 - Be more aggressive about deleting unnecessary results from the test-results-server json files
Summary: Be more aggressive about deleting unnecessary results from the test-results-s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 11:48 PST by Ojan Vafai
Modified: 2012-01-11 12:01 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.02 KB, patch)
2012-01-11 11:49 PST, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-11 11:48:55 PST
Be more aggressive about deleting unnecessary results from the test-results-server json files
Comment 1 Ojan Vafai 2012-01-11 11:49:50 PST
Created attachment 122061 [details]
Patch
Comment 2 Tony Chang 2012-01-11 11:58:04 PST
Comment on attachment 122061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122061&action=review

> Tools/TestResultServer/model/jsonresults.py:212
> +        deletable_types = set([JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA, JSON_RESULTS_SKIP])

Nit: tuple instead of list: set((JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA, JSON_RESULTS_SKIP))

> Tools/TestResultServer/model/jsonresults.py:214
> +        for result in aggregated_test[JSON_RESULTS_RESULTS]:
> +            if result[1] not in deletable_types:

Not sure if it's any better, but this could be:
if any((1 for result in aggregated_test[JSON_RESULTS_RESULTS] if result[1] not in deletable_types)):
Comment 3 Ojan Vafai 2012-01-11 12:01:37 PST
Committed r104731: <http://trac.webkit.org/changeset/104731>