Bug 76082 – [EFL] SecurityPolicy whitelist interface should be exposed to EWebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Leandro Pereira]

[EFL] SecurityPolicy whitelist interface should be exposed to EWebKit

[Leandro Pereira]

Created attachment 122075 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

People might complain that the declarations in the header span multiple lines, but that shouldn't be much of a problem IMO.

LGTM.

[Gyuyoung Kim]

Comment on attachment 122075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122075&action=review

Looks good patch itself. But, I wonder why we need to support security policy as APIs.

> Source/WebKit/efl/ChangeLog:7
> +

IMO, it is much better to add description why efl port supports this APIs.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #3)
> IMO, it is much better to add description why efl port supports this APIs.

Do you mean mentioning in the ChangeLog what the apidox says?

[Gyuyoung Kim]

(In reply to comment #4)
> (In reply to comment #3)
> > IMO, it is much better to add description why efl port supports this APIs.
> 
> Do you mean mentioning in the ChangeLog what the apidox says?

If there is description for security policy role or feature in ChangeLog, it is helpful to understand this patch for us. Because, it looks leandro contributes new files to ewk.

[Leandro Pereira]

(In reply to comment #5)
> 
> If there is description for security policy role or feature in ChangeLog, it is 
> helpful to understand this patch for us. 
>

This allows bypassing the same origin policy when making XMLHTTPRequests.

Generally not useful for web browsers, but important if you plan to create (or are already working on) Dashboard-like widgets that make requests to third-party servers; specifically if  W3C's Widget Access Request spec[1] is implemented by the library client.

The whitelist feature is already available in WebCore: this patch adds only a thin layer around it so that a EWebKit can call it.

>
> Because, it looks leandro contributes new files to ewk.
>

A new file has been added because code therein do not belong somewhere else.

[1] http://dev.w3.org/2006/waf/widgets-access/

[Gyuyoung Kim]

(In reply to comment #6)
> (In reply to comment #5)
> > 
> > If there is description for security policy role or feature in ChangeLog, it is 
> > helpful to understand this patch for us. 
> >
> 
> This allows bypassing the same origin policy when making XMLHTTPRequests.
> 
> Generally not useful for web browsers, but important if you plan to create (or are already working on) Dashboard-like widgets that make requests to third-party servers; specifically if  W3C's Widget Access Request spec[1] is implemented by the library client.
> 
> The whitelist feature is already available in WebCore: this patch adds only a thin layer around it so that a EWebKit can call it.
> 
> >
> > Because, it looks leandro contributes new files to ewk.
> >
> 
> A new file has been added because code therein do not belong somewhere else.
> 
> [1] http://dev.w3.org/2006/waf/widgets-access/

Thank you for you kindly description :-) LGTM.

[WebKit Review Bot]

Comment on attachment 122075 [details]
Patch

Clearing flags on attachment: 122075

Committed r104960: <http://trac.webkit.org/changeset/104960>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.