Bug 76081 - Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to fix compile error
Summary: Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 11:30 PST by Dmitry Titov
Modified: 2012-01-11 11:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2012-01-11 11:33 PST, Dmitry Titov 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2012-01-11 11:30:20 PST 
This is a follow-up on http://trac.webkit.org/r104678
It added a new CSS property, CSSPropertyWebkitFontKerning and this breaks compile if WebKit is built with SVG disabled.

The CSSStyleSelector::applyProperty() contains a big switch() with the following fragment at the end:

#if ENABLE(SVG)
    default:
       // Try the SVG properties
       applySVGProperty(id, value);
        return;
#endif

I'm adding the CSSPropertyWebkitFontKerning into this switch() in a non-specific manner, since I need to fix the compile error on some Chromium bots. 
Adding mitz@ to alert and perhaps do a better fix later.
Comment 1 Dmitry Titov 2012-01-11 11:33:09 PST 
Created attachment 122058 [details]
Patch
Comment 2 Dmitry Titov 2012-01-11 11:37:39 PST 
Committed r104726: <http://trac.webkit.org/changeset/104726>