Bug 76080 - Webpages flash white when switching between windows
Summary: Webpages flash white when switching between windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 11:26 PST by Anders Carlsson
Modified: 2012-01-11 11:38 PST (History)
0 users

See Also:


Attachments
Patch (4.29 KB, patch)
2012-01-11 11:27 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-01-11 11:26:40 PST
Webpages flash white when switching between windows
Comment 1 Anders Carlsson 2012-01-11 11:27:43 PST
Created attachment 122057 [details]
Patch
Comment 2 mitz 2012-01-11 11:34:20 PST
Comment on attachment 122057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122057&action=review

> Source/WebKit2/ChangeLog:9
> +        Introduce a _windowHasValidBackingStore boolean and only paint white if it's false.

Is it really unconditionally white?

> Source/WebKit2/ChangeLog:17
> +        * UIProcess/API/mac/WKView.mm:
> +        (-[WKView setFrameSize:]):
> +        (-[WKView viewDidMoveToWindow]):
> +        (-[WKView _windowDidMiniaturize:]):
> +        (-[WKView _windowDidChangeBackingProperties:]):
> +        (-[WKView drawRect:]):
> +

Please add comments here.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:192
> +    // The window server invalidates the backing store of whenever the window is resized or minimized.

Typo: “of whenever”.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1980
> +            // didn't paint with white, to avoid garbage in those areas.

Is it really always white?
Comment 3 Anders Carlsson 2012-01-11 11:38:35 PST
Committed r104727: <http://trac.webkit.org/changeset/104727>