Bug 76072 - IndexedDB: Raise NON_TRANSIENT_ERR when invalid mode specified for transaction
: IndexedDB: Raise NON_TRANSIENT_ERR when invalid mode specified for transaction
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Joshua Bell
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-11 10:08 PST by Joshua Bell
Modified: 2012-01-12 11:39 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.25 KB, patch)
2012-01-11 10:08 PST, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (5.38 KB, patch)
2012-01-11 16:08 PST, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2012-01-12 10:00 PST, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-01-11 10:08:07 PST
IndexedDB: Raise NON_TRANSIENT_ERR when invalid mode specified for transaction
Comment 1 Joshua Bell 2012-01-11 10:08:28 PST
Created attachment 122045 [details]
Patch
Comment 2 Tony Chang 2012-01-11 15:10:50 PST
Comment on attachment 122045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122045&action=review

> Source/WebCore/ChangeLog:3
> +        IndexedDB: Raise NON_TRANSIENT_ERR when invalid mode specified for transaction

Maybe mention that this has now been speced.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Mention which tests are updated here.
Comment 3 Joshua Bell 2012-01-11 16:08:51 PST
Created attachment 122116 [details]
Patch
Comment 4 Joshua Bell 2012-01-11 16:09:15 PST
Comment on attachment 122116 [details]
Patch

There we go - getting these patches confused. CL updated. tony@ ?
Comment 5 Joshua Bell 2012-01-12 09:43:35 PST
Comment on attachment 122116 [details]
Patch

Need to rebase
Comment 6 Joshua Bell 2012-01-12 10:00:18 PST
Created attachment 122265 [details]
Patch
Comment 7 Joshua Bell 2012-01-12 10:00:44 PST
Comment on attachment 122265 [details]
Patch

Rebased. tony@ - r? cq?
Comment 8 WebKit Review Bot 2012-01-12 11:39:51 PST
Comment on attachment 122265 [details]
Patch

Clearing flags on attachment: 122265

Committed r104840: <http://trac.webkit.org/changeset/104840>
Comment 9 WebKit Review Bot 2012-01-12 11:39:55 PST
All reviewed patches have been landed.  Closing bug.