Bug 76071 - Speech input: Send text to correct element even if focus has changed
Summary: Speech input: Send text to correct element even if focus has changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 09:46 PST by Hans Wennborg
Modified: 2012-01-12 06:39 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.77 KB, patch)
2012-01-11 09:49 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (5.77 KB, patch)
2012-01-12 02:53 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (5.76 KB, patch)
2012-01-12 03:16 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-01-11 09:46:35 PST
Speech input: Send text to correct element even if focus has changed
Comment 1 Hans Wennborg 2012-01-11 09:49:58 PST
Created attachment 122042 [details]
Patch
Comment 2 Hans Wennborg 2012-01-12 02:53:21 PST
Created attachment 122198 [details]
Patch

Update patch, calling selectionChanged() whether or not the focus has changed to simplify the code flow.
Comment 3 Satish Sampath 2012-01-12 02:56:02 PST
Comment on attachment 122198 [details]
Patch

Source/WebCore/html/shadow/TextControlInnerElements.cpp
> // selection has moved away from it.
should this be 'focus has moved away' ?

Looks good to me otherwise
Comment 4 Hans Wennborg 2012-01-12 03:16:42 PST
Created attachment 122201 [details]
Patch

Thanks Satish, uploading new patch that fixes the comment.
Comment 5 Steve Block 2012-01-12 05:22:18 PST
Comment on attachment 122201 [details]
Patch

r=me
Comment 6 WebKit Review Bot 2012-01-12 06:39:53 PST
Comment on attachment 122201 [details]
Patch

Clearing flags on attachment: 122201

Committed r104821: <http://trac.webkit.org/changeset/104821>
Comment 7 WebKit Review Bot 2012-01-12 06:39:58 PST
All reviewed patches have been landed.  Closing bug.