Bug 76066 - Webaudio layout tests need to override the WebKitWebAudioEnabled
Summary: Webaudio layout tests need to override the WebKitWebAudioEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 09:12 PST by Raymond Toy
Modified: 2012-01-11 13:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.55 KB, patch)
2012-01-11 11:43 PST, Raymond Toy
no flags Details | Formatted Diff | Diff
Patch (1.30 KB, patch)
2012-01-11 12:25 PST, Raymond Toy
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2012-01-11 09:12:09 PST
As noted in https://bugs.webkit.org/show_bug.cgi?id=75126#c41, we need to override the WebKitWebAudioEnabled LayoutTestController preference. It has to be set to 1.  Some existing tests have this, but most do not.
Comment 1 Raymond Toy 2012-01-11 11:43:30 PST
Created attachment 122059 [details]
Patch
Comment 2 Chris Rogers 2012-01-11 11:52:21 PST
I don't remember much about this - I just added Tony for review here...
Comment 3 Philippe Normand 2012-01-11 12:05:34 PST
Comment on attachment 122059 [details]
Patch

I initially added this in LayoutTests/webaudio/resources/audio-testing.js so at least all tests importing that js script are ok, fwiw :)
Comment 4 Tony Chang 2012-01-11 12:05:59 PST
Comment on attachment 122059 [details]
Patch

It looks like this is done by LayoutTests/webaudio/resources/audio-testing.js which is include by most of the files.  Looks like only convolution-mono-mono.html needs it added (or needs to include audio-testing.js).
Comment 5 Raymond Toy 2012-01-11 12:25:53 PST
Created attachment 122072 [details]
Patch
Comment 6 Raymond Toy 2012-01-11 12:27:00 PST
(In reply to comment #4)
> (From update of attachment 122059 [details])
> It looks like this is done by LayoutTests/webaudio/resources/audio-testing.js which is include by most of the files.  Looks like only convolution-mono-mono.html needs it added (or needs to include audio-testing.js).

Thanks.  That's a much better solution.  Updated patch accordingly.
Comment 7 WebKit Review Bot 2012-01-11 13:12:35 PST
Comment on attachment 122072 [details]
Patch

Clearing flags on attachment: 122072

Committed r104737: <http://trac.webkit.org/changeset/104737>
Comment 8 WebKit Review Bot 2012-01-11 13:12:39 PST
All reviewed patches have been landed.  Closing bug.