Bug 76062 - Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
Summary: Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 72861
  Show dependency treegraph
 
Reported: 2012-01-11 07:51 PST by Peter Rybin
Modified: 2012-01-11 09:36 PST (History)
12 users (show)

See Also:


Attachments
Patch (3.25 KB, patch)
2012-01-11 07:57 PST, Peter Rybin
no flags Details | Formatted Diff | Diff
InspectorFrontend.h base version (143.42 KB, text/plain)
2012-01-11 08:01 PST, Peter Rybin
no flags Details
New InspectorFrontend.h (141.65 KB, text/plain)
2012-01-11 08:02 PST, Peter Rybin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-01-11 07:51:27 PST
Builder template classes use enum constants as their parameters. The enum constants should be named in CamelCase rather than in ALL_CAPS_WITH_UNDERSCORE.
Comment 1 Peter Rybin 2012-01-11 07:57:02 PST
Created attachment 122023 [details]
Patch
Comment 2 Peter Rybin 2012-01-11 08:01:31 PST
Created attachment 122024 [details]
InspectorFrontend.h base version
Comment 3 Peter Rybin 2012-01-11 08:02:37 PST
Created attachment 122025 [details]
New InspectorFrontend.h
Comment 4 WebKit Review Bot 2012-01-11 09:36:35 PST
Comment on attachment 122023 [details]
Patch

Clearing flags on attachment: 122023

Committed r104716: <http://trac.webkit.org/changeset/104716>
Comment 5 WebKit Review Bot 2012-01-11 09:36:41 PST
All reviewed patches have been landed.  Closing bug.