Bug 76037 - [EFL] Move macro checking to functions' definition in ewk_js.cpp.
: [EFL] Move macro checking to functions' definition in ewk_js.cpp.
Status: RESOLVED FIXED
: WebKit
WebKit EFL
: 528+ (Nightly build)
: All Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-01-11 00:24 PST by
Modified: 2012-01-12 03:49 PST (History)


Attachments
proposed patch (5.71 KB, patch)
2012-01-11 00:26 PST, Grzegorz Czajkowski
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-01-11 00:24:53 PST
Moves macro checking to functions definitions instead of duplicate them in source depending on macro value.
It's known practice in WebKit and EFL port.
Duplicating functions in the same file whose return value is different may confuse user,
especially if macro isn't included in a patch.
------- Comment #1 From 2012-01-11 00:26:26 PST -------
Created an attachment (id=121990) [details]
proposed patch
------- Comment #2 From 2012-01-11 05:23:57 PST -------
Looks good.
------- Comment #3 From 2012-01-11 05:30:31 PST -------
LGTM. :)
------- Comment #4 From 2012-01-11 18:06:57 PST -------
(From update of attachment 121990 [details])
LGTM too. :-)
------- Comment #5 From 2012-01-12 03:48:57 PST -------
(From update of attachment 121990 [details])
Clearing flags on attachment: 121990

Committed r104806: <http://trac.webkit.org/changeset/104806>
------- Comment #6 From 2012-01-12 03:49:02 PST -------
All reviewed patches have been landed.  Closing bug.