Bug 76034 - REGRESSION(r101445): [V8] Generated code for custom getters and setters with the [Supplemental] IDL is wrong
Summary: REGRESSION(r101445): [V8] Generated code for custom getters and setters with ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency tree / graph
 
Reported: 2012-01-10 23:41 PST by Kentaro Hara
Modified: 2012-01-11 01:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.87 KB, patch)
2012-01-10 23:45 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-10 23:41:15 PST 
The class name of the implementation of custom getters and setters is wrong.

Current V8TestInterface.cpp:
    // Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy')
    {"supplementalStr3", V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},

Expected V8TestInterface.cpp:
    // Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy')
    {"supplementalStr3", V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
Comment 1 Kentaro Hara 2012-01-10 23:45:24 PST 
Created attachment 121984 [details]
Patch
Comment 2 Adam Barth 2012-01-10 23:55:34 PST 
Comment on attachment 121984 [details]
Patch

Ah, good point.
Comment 3 Adam Barth 2012-01-10 23:55:45 PST 
Sorry I missed that earlier.
Comment 4 WebKit Review Bot 2012-01-11 01:25:13 PST 
Comment on attachment 121984 [details]
Patch

Clearing flags on attachment: 121984

Committed r104684: <http://trac.webkit.org/changeset/104684>
Comment 5 WebKit Review Bot 2012-01-11 01:25:17 PST 
All reviewed patches have been landed.  Closing bug.