Bug 76024 - Update skipped file for layout test of EFL port.
Summary: Update skipped file for layout test of EFL port.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
: 75954 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-10 21:05 PST by Gyuyoung Kim
Modified: 2012-01-11 23:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (27.58 KB, patch)
2012-01-10 21:07 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (24.65 KB, patch)
2012-01-11 19:30 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-01-10 21:05:30 PST 
test_expectations.txt for EFL port is now containing list of skipped test cases. But, I could notice that file 'Skipped' is proper location for the skipped test case. In addition, some additional test cases are added to Skipped file.
Comment 1 Gyuyoung Kim 2012-01-10 21:07:24 PST 
Created attachment 121970 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-01-11 05:15:15 PST 
*** Bug 75954 has been marked as a duplicate of this bug. ***
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-01-11 05:17:49 PST 
Comment on attachment 121970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121970&action=review

Has there been any investigation on why these tests fail (like 'this one hits an assert here', 'this other one is only missing test results' etc)? Each block should also be sorted alphabetically.

> LayoutTests/platform/efl/Skipped:2036
> +http/tests/misc/error404.pl

I don't think this one is accessed directly as a test.
Comment 4 Gyuyoung Kim 2012-01-11 19:30:54 PST 
Created attachment 122158 [details]
Patch
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-01-11 20:12:40 PST 
Looks OK.
Comment 6 WebKit Review Bot 2012-01-11 23:48:58 PST 
Comment on attachment 122158 [details]
Patch

Clearing flags on attachment: 122158

Committed r104795: <http://trac.webkit.org/changeset/104795>
Comment 7 WebKit Review Bot 2012-01-11 23:49:03 PST 
All reviewed patches have been landed.  Closing bug.