Bug 76020 - [Chromium] Remove obsolete references to WebWorker class
Summary: [Chromium] Remove obsolete references to WebWorker class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry Lomov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 19:34 PST by Dmitry Lomov
Modified: 2012-01-11 09:41 PST (History)
5 users (show)

See Also:


Attachments
Fix (8.95 KB, patch)
2012-01-10 19:39 PST, Dmitry Lomov
levin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2012-01-10 19:34:49 PST
Used to represent chromium-specific implementation of dedicated web workers, unused.
Comment 1 Dmitry Lomov 2012-01-10 19:39:41 PST
Created attachment 121964 [details]
Fix
Comment 2 WebKit Review Bot 2012-01-10 19:43:56 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 David Levin 2012-01-10 20:03:09 PST
Comment on attachment 121964 [details]
Fix

What about WebWorker.h itself?
Comment 4 Dmitry Lomov 2012-01-10 20:33:27 PST
(In reply to comment #3)
> (From update of attachment 121964 [details])
> What about WebWorker.h itself?
There are stray mentions of it in chromium, will need an extra patch for that.
Comment 5 WebKit Review Bot 2012-01-10 21:42:06 PST
Comment on attachment 121964 [details]
Fix

Rejecting attachment 121964 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 117121 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 117121.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11196353
Comment 6 Adam Barth 2012-01-11 00:20:45 PST
Comment on attachment 121964 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=121964&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        Need a short description and bug URL (OOPS!)

This line is preventing this patch from being landed.
Comment 7 Dmitry Lomov 2012-01-11 09:41:42 PST
 http://trac.webkit.org/changeset/104717
Closing bug.