WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76020
[Chromium] Remove obsolete references to WebWorker class
https://bugs.webkit.org/show_bug.cgi?id=76020
Summary
[Chromium] Remove obsolete references to WebWorker class
Dmitry Lomov
Reported
2012-01-10 19:34:49 PST
Used to represent chromium-specific implementation of dedicated web workers, unused.
Attachments
Fix
(8.95 KB, patch)
2012-01-10 19:39 PST
,
Dmitry Lomov
levin
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dmitry Lomov
Comment 1
2012-01-10 19:39:41 PST
Created
attachment 121964
[details]
Fix
WebKit Review Bot
Comment 2
2012-01-10 19:43:56 PST
Please wait for approval from
fishd@chromium.org
before submitting because this patch contains changes to the Chromium public API.
David Levin
Comment 3
2012-01-10 20:03:09 PST
Comment on
attachment 121964
[details]
Fix What about WebWorker.h itself?
Dmitry Lomov
Comment 4
2012-01-10 20:33:27 PST
(In reply to
comment #3
)
> (From update of
attachment 121964
[details]
) > What about WebWorker.h itself?
There are stray mentions of it in chromium, will need an extra patch for that.
WebKit Review Bot
Comment 5
2012-01-10 21:42:06 PST
Comment on
attachment 121964
[details]
Fix Rejecting
attachment 121964
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 117121 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 117121. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output:
http://queues.webkit.org/results/11196353
Adam Barth
Comment 6
2012-01-11 00:20:45 PST
Comment on
attachment 121964
[details]
Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=121964&action=review
> Source/WebKit/chromium/ChangeLog:6 > + Need a short description and bug URL (OOPS!)
This line is preventing this patch from being landed.
Dmitry Lomov
Comment 7
2012-01-11 09:41:42 PST
http://trac.webkit.org/changeset/104717
Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug