Bug 76001 - CodeBlock.h declares too many things
Summary: CodeBlock.h declares too many things
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-01-10 15:49 PST by Filip Pizlo
Modified: 2012-01-10 16:19 PST (History)
2 users (show)

See Also:

Attachments
the patch (47.30 KB, patch)
2012-01-10 15:51 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (47.59 KB, patch)
2012-01-10 15:53 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (47.60 KB, patch)
2012-01-10 15:56 PST, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-01-10 15:49:16 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-01-10 15:51:05 PST 
Created attachment 121924 [details]
the patch
Comment 2 Filip Pizlo 2012-01-10 15:53:42 PST 
Created attachment 121926 [details]
the patch

Actually wrote a change log.
Comment 3 Filip Pizlo 2012-01-10 15:54:44 PST 
<rdar://problem/10672746>
Comment 4 WebKit Review Bot 2012-01-10 15:55:37 PST 
Attachment 121924 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2012-01-10 15:56:59 PST 
Created attachment 121928 [details]
the patch

Fix style.
Comment 6 WebKit Review Bot 2012-01-10 15:58:22 PST 
Attachment 121926 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2012-01-10 16:19:35 PST 
Landed in http://trac.webkit.org/changeset/104646