RESOLVED FIXED 75989
Hang opening movie that requires authentication 
https://bugs.webkit.org/show_bug.cgi?id=75989
Summary Hang opening movie that requires authentication
Anders Carlsson
Reported 2012-01-10 13:27:22 PST
Hang opening movie that requires authentication
Attachments
Patch (75.26 KB, patch)
2012-01-10 13:54 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-01-10 13:54:14 PST
Created attachment 121901 [details] Patch
Sam Weinig
Comment 2 2012-01-10 14:36:46 PST
Comment on attachment 121901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121901&action=review > Source/WebKit2/ChangeLog:10 > + 1. When a keychain call is made, the web process send an asynchronous request message to the UI process, Typo: send -> sends. > Source/WebKit2/ChangeLog:13 > + avoiding the need to bounce calls to the main thread (since CoreIPC only allows sending > + synchronous messages from the main thread). Incidentally, this fixes <rdar://problem/9428041>. > + 2. The Web Process now waits (on a condition variable) for a reply message to come in. This could be made clearer that it is happening off the main thread. > Source/WebKit2/Shared/mac/SecKeychainItemRequestData.h:81 > + struct Attributes : public RefCounted<Attributes> { This should be ThreadSafeRefCounted.
Anders Carlsson
Comment 3 2012-01-10 14:51:00 PST
Committed r104633: <http://trac.webkit.org/changeset/104633>
Note You need to log in before you can comment on or make changes to this bug.