RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer()/paintLayerContents() have a lot of code in common. Find a way to refactor the methods to avoid duplicate code.
Created attachment 122243 [details] Patch V1
Haven't sent for review yet. I want to see the EWS results first.
Pasted the new code to http://pastebin.com/YsLaD1Ez to make it easier to see the actual source.
Comment on attachment 122243 [details] Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=122243&action=review > Source/WebCore/rendering/RenderLayer.cpp:2724 > + // PaintLayerAppliedTransform is still being used for RenderReplica. This comment is a bit confusing. It's not clear to me if it's a FIXME or what. > Source/WebCore/rendering/RenderLayer.h:442 > + PaintLayerPaintingBackgroundPhase = 1 << 5, > + PaintLayerPaintingForegroundPhase = 1 << 6, > + PaintLayerPaintingMaskPhase = 1 << 7, I think it might help to have 'compositing' in these names. PaintLayerPaintingCompositingBackgroundPhase etc.
Created attachment 122390 [details] Patch for landing
Comment on attachment 122390 [details] Patch for landing Clearing flags on attachment: 122390 Committed r104903: <http://trac.webkit.org/changeset/104903>
All reviewed patches have been landed. Closing bug.