Bug 75980 - Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
Summary: Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 11:47 PST by mitz
Modified: 2012-01-10 12:03 PST (History)
0 users

See Also:

Attachments
Patch (1.33 KB, patch)
2012-01-10 11:48 PST, mitz 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2012-01-10 11:56 PST, mitz 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2012-01-10 11:59 PST, mitz 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-01-10 11:47:20 PST 
Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
Comment 1 mitz 2012-01-10 11:48:31 PST 
Created attachment 121881 [details]
Patch
Comment 2 Darin Adler 2012-01-10 11:51:43 PST 
Comment on attachment 121881 [details]
Patch

Maybe you should have used initWithWebCoreHistoryItem instead?
Comment 3 mitz 2012-01-10 11:56:24 PST 
Created attachment 121885 [details]
Patch
Comment 4 Mark Rowe (bdash) 2012-01-10 11:58:44 PST 
Comment on attachment 121885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121885&action=review

> Source/WebKit/mac/History/WebHistoryItem.mm:145
> +    historyItemWrappers().set(core(_private), copy);

I think you want core(copy->_private) here.
Comment 5 mitz 2012-01-10 11:59:00 PST 
Created attachment 121886 [details]
Patch
Comment 6 mitz 2012-01-10 12:03:16 PST 
Committed <http://trac.webkit.org/r104613>.