Bug 75977 – [GTK] Linking of big binaries should be serialized to avoid thrashing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

WebKitPluginProcess, libwebkitgtk, and libwebkit2gtk are huge libraries when built in debug mode and can exhaust the available memory pretty easily when linked at the same time. We Their linking should be serialized.

[Gustavo Noronha (kov)]

Created attachment 121878 [details]
Proposed patch

I'm doing a test build with --no-webkit2 to make sure it works, Philippe, but I couldn't see a reason for it not to =). More details on the trick to adding dependencies to automake targets: http://old.nabble.com/side-stepping-automake-limitations-with-custom-dependencies-td31907825.html

[Gustavo Noronha (kov)]

OK, my --no-webkit2 build worked =)

[Martin Robinson]

Comment on attachment 121878 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121878&action=review

This is awesome.

> Source/WebKit2/GNUmakefile.am:1017
> +WEBKIT2GTKLIBFORDEP = libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la

We've been using names_like_this recently in automake files. Do you mind changing this to something like webkit2gtk_lib_for_dep

> Source/WebKit2/GNUmakefile.am:1280
> +# Serialize linking of the plugin process with both webkit libraries

Super nit: missing a period at the end of this line.

> Source/WebKit2/GNUmakefile.am:1281
> +PLUGINPROCFORDEP = Programs/WebKitPluginProcess

Ditto with the caps.

[Gustavo Noronha (kov)]

Committed r104706: <http://trac.webkit.org/changeset/104706>

[Gustavo Noronha (kov)]

Comment on attachment 121878 [details]
Proposed patch

Clearing review flag