Bug 75977 - [GTK] Linking of big binaries should be serialized to avoid thrashing
Summary: [GTK] Linking of big binaries should be serialized to avoid thrashing
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
Keywords: Gtk
Depends on:
Reported: 2012-01-10 11:30 PST by Gustavo Noronha (kov)
Modified: 2012-01-11 05:55 PST (History)
3 users (show)

See Also:

Proposed patch (2.65 KB, patch)
2012-01-10 11:35 PST, Gustavo Noronha (kov)
mrobinson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2012-01-10 11:30:02 PST
WebKitPluginProcess, libwebkitgtk, and libwebkit2gtk are huge libraries when built in debug mode and can exhaust the available memory pretty easily when linked at the same time. We Their linking should be serialized.
Comment 1 Gustavo Noronha (kov) 2012-01-10 11:35:17 PST
Created attachment 121878 [details]
Proposed patch

I'm doing a test build with --no-webkit2 to make sure it works, Philippe, but I couldn't see a reason for it not to =). More details on the trick to adding dependencies to automake targets: http://old.nabble.com/side-stepping-automake-limitations-with-custom-dependencies-td31907825.html
Comment 2 Gustavo Noronha (kov) 2012-01-10 13:24:52 PST
OK, my --no-webkit2 build worked =)
Comment 3 Martin Robinson 2012-01-10 23:54:54 PST
Comment on attachment 121878 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121878&action=review

This is awesome.

> Source/WebKit2/GNUmakefile.am:1017

We've been using names_like_this recently in automake files. Do you mind changing this to something like webkit2gtk_lib_for_dep

> Source/WebKit2/GNUmakefile.am:1280
> +# Serialize linking of the plugin process with both webkit libraries

Super nit: missing a period at the end of this line.

> Source/WebKit2/GNUmakefile.am:1281
> +PLUGINPROCFORDEP = Programs/WebKitPluginProcess

Ditto with the caps.
Comment 4 Gustavo Noronha (kov) 2012-01-11 05:54:47 PST
Committed r104706: <http://trac.webkit.org/changeset/104706>
Comment 5 Gustavo Noronha (kov) 2012-01-11 05:55:31 PST
Comment on attachment 121878 [details]
Proposed patch

Clearing review flag