Bug 75968 - Web Inspector: make source urls relative to source map url.
Summary: Web Inspector: make source urls relative to source map url.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 09:05 PST by Pavel Podivilov
Modified: 2012-01-12 03:55 PST (History)
10 users (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2012-01-10 09:06 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2012-01-11 07:07 PST, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-01-10 09:05:00 PST 
Web Inspector: make source urls relative to source map url.
Comment 1 Pavel Podivilov 2012-01-10 09:06:37 PST 
Created attachment 121858 [details]
Patch
Comment 2 Yury Semikhatsky 2012-01-11 06:34:44 PST 
Comment on attachment 121858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121858&action=review

> Source/WebCore/inspector/front-end/CompilerSourceMapping.js:273
> +    _canonicalizeURL: function(url, baseURL)

This is second definition of _canonicalizeURL in this prototype. Please remove the one above.

> LayoutTests/http/tests/inspector/resources/source-map.json:4
> +"sourceRoot": "",

Why did this line change?
Comment 3 Pavel Podivilov 2012-01-11 07:07:43 PST 
Created attachment 122016 [details]
Patch
Comment 4 Pavel Podivilov 2012-01-11 07:10:34 PST 
(In reply to comment #2)
> (From update of attachment 121858 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121858&action=review
> 
> > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:273
> > +    _canonicalizeURL: function(url, baseURL)
> 
> This is second definition of _canonicalizeURL in this prototype. Please remove the one above.

Done.

> 
> > LayoutTests/http/tests/inspector/resources/source-map.json:4
> > +"sourceRoot": "",
> 
> Why did this line change?

Sources are now relative to source map. In this test source map and sources are in the same directory, so sourceRoot could be empty.
Comment 5 Pavel Podivilov 2012-01-12 03:55:11 PST 
Committed r104808: <http://trac.webkit.org/changeset/104808>