WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75966
[Chromium] Cleanup test expectations for mac.
https://bugs.webkit.org/show_bug.cgi?id=75966
Summary
[Chromium] Cleanup test expectations for mac.
John Knottenbelt
Reported
2012-01-10 08:41:11 PST
[Chromium] Cleanup test expectations for mac.
Attachments
Patch
(3.00 KB, patch)
2012-01-10 08:42 PST
,
John Knottenbelt
no flags
Details
Formatted Diff
Diff
Patch
(2.98 KB, patch)
2012-01-10 08:45 PST
,
John Knottenbelt
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
John Knottenbelt
Comment 1
2012-01-10 08:42:17 PST
Created
attachment 121853
[details]
Patch
John Knottenbelt
Comment 2
2012-01-10 08:44:12 PST
Some duplicate test expectations for mac. I've removed the earlier ones as it seems that you expect these tests to fail across the board now.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/4794/steps/webkit_tests/logs/stdio
2012-01-10 08:26:04,874 842 test_expectations.py:794 ERROR FAILURES FOR <leopard, x86, debug, cpu> in /b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 08:26:04,874 842 test_expectations.py:797 ERROR Line:3098 More specific entry on line 3098 overrides line 937 svg/W3C-SVG-1.1/filters-color-01-b.svg 2012-01-10 08:26:04,874 842 test_expectations.py:797 ERROR Line:3105 More specific entry on line 3105 overrides line 938 svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html 2012-01-10 08:26:04,874 842 test_expectations.py:797 ERROR Line:3106 More specific entry on line 3106 overrides line 939 svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html 2012-01-10 08:26:04,874 842 test_expectations.py:797 ERROR Line:3107 More specific entry on line 3107 overrides line 940 svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html 2012-01-10 08:26:04,874 842 test_expectations.py:797 ERROR Line:3108 More specific entry on line 3108 overrides line 941 svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html Traceback (most recent call last): File "/b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 424, in <module> sys.exit(main()) File "/b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 419, in main return run(port, options, args) File "/b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 84, in run manager.parse_expectations() File "/b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 393, in parse_expectations port.test_expectations_overrides()) File "/b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 712, in __init__ self._report_errors() File "/b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 802, in _report_errors raise ParseError(fatal=True, errors=[failure_title] + errors) webkitpy.layout_tests.models.test_expectations.ParseError: FAILURES FOR <leopard, x86, debug, cpu> in /b/build/slave/Webkit_Mac10_5__dbg__1_/build/src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt Line:3098 More specific entry on line 3098 overrides line 937 svg/W3C-SVG-1.1/filters-color-01-b.svg Line:3105 More specific entry on line 3105 overrides line 938 svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html Line:3106 More specific entry on line 3106 overrides line 939 svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html Line:3107 More specific entry on line 3107 overrides line 940 svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html Line:3108 More specific entry on line 3108 overrides line 941 svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html
John Knottenbelt
Comment 3
2012-01-10 08:45:21 PST
Created
attachment 121854
[details]
Patch
John Knottenbelt
Comment 4
2012-01-10 08:46:13 PST
Committed
r104583
: <
http://trac.webkit.org/changeset/104583
>
Stephen White
Comment 5
2012-01-10 09:14:45 PST
Thanks. I thought the style bot checked these now, but I guess it doesn't. Sorry!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug