Instead of (style()->position() == AbsolutePosition || style()->position() == FixedPosition) use (style()->isAbsolutelyPositioned()). Instead of (style()->position() != AbsolutePosition && style()->position() != FixedPosition) use (!style()->isAbsolutelyPositioned()).
Created attachment 121847 [details] Patch
Should we name the function isPositioned() to match the function on RenderObject?
(In reply to comment #2) > Should we name the function isPositioned() to match the function on RenderObject? I initially thought so, but i decided to name it after looking at the phrase "absolutely positioned element" from http://www.w3.org/TR/CSS2/visuren.html#absolute-positioning.
Comment on attachment 121847 [details] Patch Agree with Tony. Would prefer isPositioned.
Created attachment 122086 [details] Patch 2
Comment on attachment 122086 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=122086&action=review > Source/WebCore/rendering/RenderObject.cpp:629 > + if (!last->isText() && (last->style()->isPositioned())) { Nit: Remove extra ()s. > Source/WebCore/rendering/RenderObject.cpp:669 > + if (b && !alreadyDirty && markParents && (isText() || (!style()->isPositioned()))) Nit: Remove extra ()s.
Created attachment 122184 [details] Patch for landing
Comment on attachment 122184 [details] Patch for landing Clearing flags on attachment: 122184 Committed r104802: <http://trac.webkit.org/changeset/104802>
All reviewed patches have been landed. Closing bug.