RESOLVED FIXED 75959
Add RenderStyle::isPositioned() helper method 
https://bugs.webkit.org/show_bug.cgi?id=75959
Summary Add RenderStyle::isPositioned() helper method
Mihnea Ovidenie
Reported 2012-01-10 06:42:28 PST
Instead of (style()->position() == AbsolutePosition || style()->position() == FixedPosition) use (style()->isAbsolutelyPositioned()). Instead of (style()->position() != AbsolutePosition && style()->position() != FixedPosition) use (!style()->isAbsolutelyPositioned()).
Attachments
Patch (6.87 KB, patch)
2012-01-10 07:55 PST, Mihnea Ovidenie 		hyatt: review-
hyatt: commit-queue-
DetailsFormatted DiffDiff
Patch 2 (6.74 KB, patch)
2012-01-11 13:40 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.13 KB, patch)
2012-01-12 00:48 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-01-10 07:55:37 PST
Created attachment 121847 [details] Patch
Tony Chang
Comment 2 2012-01-10 09:43:35 PST
Should we name the function isPositioned() to match the function on RenderObject?
Mihnea Ovidenie
Comment 3 2012-01-10 10:03:01 PST
(In reply to comment #2) > Should we name the function isPositioned() to match the function on RenderObject? I initially thought so, but i decided to name it after looking at the phrase "absolutely positioned element" from http://www.w3.org/TR/CSS2/visuren.html#absolute-positioning.
Dave Hyatt
Comment 4 2012-01-11 12:53:57 PST
Comment on attachment 121847 [details] Patch Agree with Tony. Would prefer isPositioned.
Mihnea Ovidenie
Comment 5 2012-01-11 13:40:59 PST
Created attachment 122086 [details] Patch 2
Tony Chang
Comment 6 2012-01-11 13:45:59 PST
Comment on attachment 122086 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=122086&action=review > Source/WebCore/rendering/RenderObject.cpp:629 > + if (!last->isText() && (last->style()->isPositioned())) { Nit: Remove extra ()s. > Source/WebCore/rendering/RenderObject.cpp:669 > + if (b && !alreadyDirty && markParents && (isText() || (!style()->isPositioned()))) Nit: Remove extra ()s.
Mihnea Ovidenie
Comment 7 2012-01-12 00:48:40 PST
Created attachment 122184 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-01-12 02:23:04 PST
Comment on attachment 122184 [details] Patch for landing Clearing flags on attachment: 122184 Committed r104802: <http://trac.webkit.org/changeset/104802>
WebKit Review Bot
Comment 9 2012-01-12 02:23:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.