Bug 75955 – Web Inspector: add "free flow DOM editing" experiment.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

This change enables HTML editing from Resources panel.

[Pavel Feldman]

Created attachment 121836 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 121836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121836&action=review

> Source/WebCore/inspector/DOMEditor.cpp:75
> +            OwnPtr<NodeDigest> oInfo = createNodeDigest(oldElement);

We don't use abbreviations in WebKit

> Source/WebCore/inspector/DOMEditor.cpp:76
> +            OwnPtr<NodeDigest> nInfo = createNodeDigest(newElement);

ditto

> Source/WebCore/inspector/DOMEditor.cpp:127
> +    // Trim tail

Period at the end.

> Source/WebCore/inspector/DOMEditor.cpp:135
> +    // Trim head

Period at the end.

> Source/WebCore/inspector/DOMEditor.cpp:167
> +        if (nit->second.size() != 1)

newIt?

> Source/WebCore/inspector/DOMEditor.cpp:170
> +        DiffTable::iterator oit = oldTable.find(nit->first);

oldIt?

> Source/WebCore/inspector/DOMEditor.cpp:184
> +            newMap[i + 1] = std::make_pair(newList[i + 1].get(), j);

The standard way is
using namespace std;
at the beginning (I've been pointed at it a couple times - kling et al.)

> Source/WebCore/inspector/InspectorDOMAgent.cpp:649
> +        *errorString = "Editing detached nodes is not supported";

... of detached nodes...

[Yury Semikhatsky]

Comment on attachment 121836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121836&action=review

> Source/WebCore/inspector/DOMEditor.cpp:228
> +        RefPtr<Node> adoptedNode = oldParent->ownerDocument()->adoptNode(node, ec);

doesn't insertBefore do adoptNode?

> Source/WebCore/inspector/DOMEditor.h:50
> +    DOMEditor(Document*);

explicit

> Source/WebCore/inspector/DOMEditor.h:56
> +    struct NodeDigest {

Forward declaration should be enough.

> Source/WebCore/inspector/DOMEditor.h:57
> +        NodeDigest(Node*);

explicit

[Pavel Feldman]

Committed r104586: <http://trac.webkit.org/changeset/104586>

[Jessie Berlin]

(In reply to comment #4)
> Committed r104586: <http://trac.webkit.org/changeset/104586>

This broke the build:

http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Build%29/builds/5430/steps/compile-webkit/logs/stdio