Bug 75942 - [Refactoring] Rename attributes in TestSupplemental.idl to clarify that they are supplemental attributes
Summary: [Refactoring] Rename attributes in TestSupplemental.idl to clarify that they ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency tree / graph
 
Reported: 2012-01-10 00:05 PST by Kentaro Hara
Modified: 2012-01-10 15:36 PST (History)
5 users (show)

See Also:

Attachments
Patch (28.35 KB, patch)
2012-01-10 00:10 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (28.06 KB, patch)
2012-01-10 00:12 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-10 00:05:57 PST 
To make the test result of TestSupplemental.idl readable (i.e. to make it easy to find in {JS,V8,ObjC,GObject,CPP}TestInterface.cpp which attributes originate from TestSupplemental.idl), we should rename the attributes in TestSupplemental.idl, like this:

Before:
    interface [
        Supplemental=TestInterface
    ] TestSupplemental {
        readonly attribute DOMString str1;
        attribute DOMString str2;
        attribute [CustomGetter, CustomSetter] str3;
    };

After:
    interface [
        Supplemental=TestInterface
    ] TestSupplemental {
        readonly attribute DOMString supplementalStr1;
        attribute DOMString supplementalStr2;
        attribute [CustomGetter, CustomSetter] supplementalStr3;
    };
Comment 1 Kentaro Hara 2012-01-10 00:10:13 PST 
Created attachment 121803 [details]
Patch
Comment 2 Kentaro Hara 2012-01-10 00:12:08 PST 
Created attachment 121804 [details]
Patch
Comment 3 WebKit Review Bot 2012-01-10 00:12:57 PST 
Attachment 121803 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h:60:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2012-01-10 15:35:56 PST 
Comment on attachment 121804 [details]
Patch

Clearing flags on attachment: 121804

Committed r104639: <http://trac.webkit.org/changeset/104639>
Comment 5 WebKit Review Bot 2012-01-10 15:36:01 PST 
All reviewed patches have been landed.  Closing bug.