WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75942
[Refactoring] Rename attributes in TestSupplemental.idl to clarify that they are supplemental attributes
https://bugs.webkit.org/show_bug.cgi?id=75942
Summary
[Refactoring] Rename attributes in TestSupplemental.idl to clarify that they ...
Kentaro Hara
Reported
2012-01-10 00:05:57 PST
To make the test result of TestSupplemental.idl readable (i.e. to make it easy to find in {JS,V8,ObjC,GObject,CPP}TestInterface.cpp which attributes originate from TestSupplemental.idl), we should rename the attributes in TestSupplemental.idl, like this: Before: interface [ Supplemental=TestInterface ] TestSupplemental { readonly attribute DOMString str1; attribute DOMString str2; attribute [CustomGetter, CustomSetter] str3; }; After: interface [ Supplemental=TestInterface ] TestSupplemental { readonly attribute DOMString supplementalStr1; attribute DOMString supplementalStr2; attribute [CustomGetter, CustomSetter] supplementalStr3; };
Attachments
Patch
(28.35 KB, patch)
2012-01-10 00:10 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Patch
(28.06 KB, patch)
2012-01-10 00:12 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-01-10 00:10:13 PST
Created
attachment 121803
[details]
Patch
Kentaro Hara
Comment 2
2012-01-10 00:12:08 PST
Created
attachment 121804
[details]
Patch
WebKit Review Bot
Comment 3
2012-01-10 00:12:57 PST
Attachment 121803
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h:60: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 4
2012-01-10 15:35:56 PST
Comment on
attachment 121804
[details]
Patch Clearing flags on attachment: 121804 Committed
r104639
: <
http://trac.webkit.org/changeset/104639
>
WebKit Review Bot
Comment 5
2012-01-10 15:36:01 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug