Bug 75923 - [chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
Summary: [chromium] Pasteboard::documentFragment should fall back to text if there's n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 18:27 PST by Daniel Cheng
Modified: 2012-01-10 17:19 PST (History)
0 users

See Also:


Attachments
Patch (1.89 KB, patch)
2012-01-09 18:48 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2012-01-10 13:55 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2012-01-09 18:27:59 PST
This matches the behavior of the other ports and prevents buggy programs like gvim from breaking pasting in richly editable areas.
Comment 1 Daniel Cheng 2012-01-09 18:48:26 PST
Created attachment 121780 [details]
Patch
Comment 2 Evan Martin 2012-01-09 20:42:33 PST
Comment on attachment 121780 [details]
Patch

You'll need a test before any reviewer will r+ this
Comment 3 Daniel Cheng 2012-01-09 21:04:09 PST
I'd need to add something to LayoutTestController (in the WebKit tree) which would poke at the internal bits of MockWebClipboardImpl (in the Chromium tree). If someone can suggest an elegant way to do this, then sure, but otherwise it's not feasible.
Comment 4 Daniel Cheng 2012-01-10 13:55:10 PST
Created attachment 121902 [details]
Patch
Comment 5 Daniel Cheng 2012-01-10 13:56:02 PST
Comment on attachment 121902 [details]
Patch

This change requires a small change in the Chromium side, so CQ- until I land that change and roll the chromium deps in WebKit.
Comment 6 Daniel Cheng 2012-01-10 16:40:15 PST
I've landed the DEPS roll at http://trac.webkit.org/changeset/104650.
Comment 7 Daniel Cheng 2012-01-10 17:19:21 PST
Comment on attachment 121902 [details]
Patch

Clearing flags on attachment: 121902

Committed r104655: <http://trac.webkit.org/changeset/104655>
Comment 8 Daniel Cheng 2012-01-10 17:19:24 PST
All reviewed patches have been landed.  Closing bug.