Bug 75921 - [Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
Summary: [Mac] Accelerate canvas layers with the same logic as accelerating the canvas...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 18:14 PST by Matthew Delaney
Modified: 2012-01-10 12:31 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.44 KB, patch)
2012-01-09 18:22 PST, Matthew Delaney
no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2012-01-09 18:27 PST, Matthew Delaney
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2012-01-09 18:14:37 PST
Unblocking our desired lazy allocation of canvas backing stores via http://trac.webkit.org/changeset/96624/trunk introduced the issue of timing problems when asking if a canvas is accelerated or not. For example, when deciding whether or not to set accelerates drawing on a layer we ask if the canvas is accelerated. If the canvas isn't fully created, we might not know if it's accelerated or not, so we default to returning false. So, we can avoid this issue if we just instead accelerate the layer based off the same logic the canvas would use, namely HTMLCanvasElement::shouldAccelerate().
Comment 1 Matthew Delaney 2012-01-09 18:22:57 PST
Created attachment 121778 [details]
Patch
Comment 2 Matthew Delaney 2012-01-09 18:27:48 PST
Created attachment 121779 [details]
Patch
Comment 3 Matthew Delaney 2012-01-10 12:31:03 PST
Committed r104616: <http://trac.webkit.org/changeset/104616>