Bug 75915 - CSS transitions should work on the flex property
Summary: CSS transitions should work on the flex property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2012-01-09 17:09 PST by Tony Chang
Modified: 2012-04-04 16:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.53 KB, patch)
2012-02-03 17:02 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2012-04-04 13:49 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-01-09 17:09:53 PST 
It should be possible to transition from flex() to flex() or from a length to flex() or from flex() to length.
Comment 1 Tony Chang 2012-02-03 17:02:40 PST 
Created attachment 125449 [details]
Patch
Comment 2 Hajime Morrita 2012-02-20 20:58:47 PST 
It looks the test compares the value as a number (float), not a tuple of the numbers. 
Is it intentional? (Disclaimer: I'm not a flexbox expert.)
Comment 3 Tony Chang 2012-02-21 13:51:49 PST 
Comment on attachment 125449 [details]
Patch

The spec is changing so this patch isn't correct anymore. I'll post a new patch when we're ready.
Comment 4 Tony Chang 2012-04-04 13:49:27 PDT 
Created attachment 135668 [details]
Patch
Comment 5 Ojan Vafai 2012-04-04 14:31:27 PDT 
Patch looks good to me. Someone with transitions experience should probably r+ though.
Comment 6 Dean Jackson 2012-04-04 15:50:26 PDT 
Comment on attachment 135668 [details]
Patch

Cool!
Comment 7 WebKit Review Bot 2012-04-04 16:57:51 PDT 
Comment on attachment 135668 [details]
Patch

Clearing flags on attachment: 135668

Committed r113264: <http://trac.webkit.org/changeset/113264>
Comment 8 WebKit Review Bot 2012-04-04 16:57:56 PDT 
All reviewed patches have been landed.  Closing bug.