Bug 75912 - [chromium] Correctly recreate DrawingBuffer on lost device
Summary: [chromium] Correctly recreate DrawingBuffer on lost device
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: John Bauman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 16:45 PST by John Bauman
Modified: 2012-01-10 15:19 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2012-01-09 16:50 PST, John Bauman
no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2012-01-09 16:56 PST, John Bauman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Bauman 2012-01-09 16:45:06 PST
[chromium] Correctly recreate DrawingBuffer on lost device
Comment 1 John Bauman 2012-01-09 16:50:10 PST
Created attachment 121760 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-09 16:52:44 PST
Attachment 121760 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 John Bauman 2012-01-09 16:56:31 PST
Created attachment 121761 [details]
Patch
Comment 4 Jeff Timanus 2012-01-10 08:33:52 PST
Comment on attachment 121761 [details]
Patch

Thanks for catching this, John.
LGTM.
Comment 5 Kenneth Russell 2012-01-10 10:21:47 PST
Comment on attachment 121761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121761&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests.

Have you tried to use LayoutTestController.loseCompositorContext() (see LayoutTests/platform/chromium/compositing/) or the WEBGL_lose_context extension (see LayoutTests/fast/canvas/webgl/) to force execution of this code path?

In general we should add a test each time an issue like this is discovered to prevent future regressions. However, if the above primitives don't allow testing of this code path then I won't hold it up.
Comment 6 Kenneth Russell 2012-01-10 14:13:13 PST
Comment on attachment 121761 [details]
Patch

After offline discussion it seems like the WEBGL_lose_context extension would need to lose the context at a deeper level in order to test this code path. Given that, r+'ing as is to get this fix in now.
Comment 7 WebKit Review Bot 2012-01-10 15:19:16 PST
Comment on attachment 121761 [details]
Patch

Clearing flags on attachment: 121761

Committed r104636: <http://trac.webkit.org/changeset/104636>
Comment 8 WebKit Review Bot 2012-01-10 15:19:20 PST
All reviewed patches have been landed.  Closing bug.