run-bindings-tests should exercise all the IDL attributes we use
Created attachment 121747 [details] Patch
Comment on attachment 121747 [details] Patch I like tests.
Attachment 121747 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Last 3072 characters of output: Core/bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:21: #ifndef header guard has wrong style, please use: WebKitDOMTestActiveDOMObjectPrivate_h [build/header_guard] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h:42: The parameter name "str" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h:54: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h:61: More than one command on the same line in if [whitespace/parens] [4] Source/WebCore/bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h:57: More than one command on the same line in if [whitespace/parens] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:21: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:22: Found WebCore config.h after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:24: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:131: Declaration has space between type name and * in GObjectClass *gobjectClass [whitespace/declaration] [3] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp:156: Extra space between return and WEBKIT_DOM_TEST_OVERRIDING_NAME_GETTER [whitespace/declaration] [3] Total errors found: 75 in 57 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 121747 [details] Patch Clearing flags on attachment: 121747 Committed r104526: <http://trac.webkit.org/changeset/104526>
All reviewed patches have been landed. Closing bug.