Bug 75890 - Small typo in AudioPannerNode.cpp
Summary: Small typo in AudioPannerNode.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 14:23 PST by Raymond Toy
Modified: 2012-02-21 18:42 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2012-02-21 14:19 PST, Raymond Toy
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2012-01-09 14:23:04 PST
I think there's a small typo in AudioPannerNode.cpp near line 210:


    // Elevation
    double elevation = 90.0 - 180.0 * acos(sourceListener.dot(up)) / piDouble;
    fixNANs(azimuth); // avoid illegal values

That fixNANs should probably be elevation, not azimuth, because we tested that at line 197.
Comment 1 Chris Rogers 2012-01-12 15:10:44 PST
Probably easiest to just fix this as part of the other equal-power panner bug:
https://bugs.webkit.org/show_bug.cgi?id=75767
Comment 2 Chris Rogers 2012-02-19 00:46:06 PST
Ray, could you please provide the fix here -- it seems easy...
Comment 3 Raymond Toy 2012-02-21 14:19:59 PST
Created attachment 128046 [details]
Patch
Comment 4 WebKit Review Bot 2012-02-21 18:42:22 PST
Comment on attachment 128046 [details]
Patch

Clearing flags on attachment: 128046

Committed r108430: <http://trac.webkit.org/changeset/108430>
Comment 5 WebKit Review Bot 2012-02-21 18:42:26 PST
All reviewed patches have been landed.  Closing bug.