RESOLVED FIXED 75890
Small typo in AudioPannerNode.cpp 
https://bugs.webkit.org/show_bug.cgi?id=75890
Summary Small typo in AudioPannerNode.cpp
Raymond Toy
Reported 2012-01-09 14:23:04 PST
I think there's a small typo in AudioPannerNode.cpp near line 210: // Elevation double elevation = 90.0 - 180.0 * acos(sourceListener.dot(up)) / piDouble; fixNANs(azimuth); // avoid illegal values That fixNANs should probably be elevation, not azimuth, because we tested that at line 197.
Attachments
Patch (1.41 KB, patch)
2012-02-21 14:19 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-01-12 15:10:44 PST
Probably easiest to just fix this as part of the other equal-power panner bug: https://bugs.webkit.org/show_bug.cgi?id=75767
Chris Rogers
Comment 2 2012-02-19 00:46:06 PST
Ray, could you please provide the fix here -- it seems easy...
Raymond Toy
Comment 3 2012-02-21 14:19:59 PST
Created attachment 128046 [details] Patch
WebKit Review Bot
Comment 4 2012-02-21 18:42:22 PST
Comment on attachment 128046 [details] Patch Clearing flags on attachment: 128046 Committed r108430: <http://trac.webkit.org/changeset/108430>
WebKit Review Bot
Comment 5 2012-02-21 18:42:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.