Bug 75889 - [Qt][WK2] Remove workaround introduced into bug 75470
Summary: [Qt][WK2] Remove workaround introduced into bug 75470
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 14:15 PST by Hugo Parente Lima
Modified: 2012-01-12 10:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.10 KB, patch)
2012-01-09 14:24 PST, Hugo Parente Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugo Parente Lima 2012-01-09 14:15:08 PST 
Remove QML workaround introduced into bug 75470, clip property is working again.
Tested on Qt5 rev. f917ea79ef75917ce9f7d166fd5f8e2b772b9058
Comment 1 Hugo Parente Lima 2012-01-09 14:24:58 PST 
Created attachment 121725 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-11 09:49:58 PST 
Comment on attachment 121725 [details]
Patch

Clearing flags on attachment: 121725

Committed r104718: <http://trac.webkit.org/changeset/104718>
Comment 3 WebKit Review Bot 2012-01-11 09:50:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Balazs Kelemen 2012-01-12 06:12:18 PST 
Well, I think this was a bit too early to remove that since most of us use the qt5 version that we have on the bot and that one would still need the workaround.
Normally Ossy updates it weekly, however now it's a bit older because qt5 trunk was buggy. Not a big problem of course, but next time please take this into consideration. I think the most straightforward is to use the bot's qt5 version for development. Anyway, no need to revert this, tomorrow Ossy will update and we can live with that for a day.
Comment 5 Tor Arne Vestbø 2012-01-12 06:32:45 PST 
Sorry about that :/
Comment 6 Hugo Parente Lima 2012-01-12 10:05:24 PST 
Yep, this is why I did put the hash of Qt5 I used to test it. Anyway my fault for upload the patch too early.

P.S.: I did need to update my Qt5 to avoid some segfaults and slowness on QtQuick that were already fixed, this is why I'm using a Qt different from the used on build bots.