Bug 75885 – [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Zeno Albisser]

The following shortcuts do not work reliably in MiniBrowser: Ctrl+R & Ctrl+L.

[Zeno Albisser]

Created attachment 121720 [details]
patch for review.

Doing this in C++ is the only reliable way due to the event delivery mechanism in QML.

[Kenneth Rohde Christiansen]

Comment on attachment 121720 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=121720&action=review

> Tools/ChangeLog:7
> +        [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
> +        https://bugs.webkit.org/show_bug.cgi?id=75885
> +
> +        Reviewed by NOBODY (OOPS!).
> +

A bit more description would be nice. Was the original code wrong? or is it due to bugs in QML? etc

[Zeno Albisser]

Created attachment 121745 [details]
patch for review. - same content, but some more ChangeLog.

[Kenneth Rohde Christiansen]

Comment on attachment 121745 [details]
patch for review. - same content, but some more ChangeLog.

View in context: https://bugs.webkit.org/attachment.cgi?id=121745&action=review

> Tools/ChangeLog:10
> +        In QML events are propagated through parents. But since the
> +        WebView may consume key events, a shortcut might never reach
> +        the top QtQuickItem.
> +        Therefore an application wide event handling function in C++
> +        needs to take care of shortcuts for MiniBrowser.

Way better... now a small comment in the code would be quite nice. like in the notify method

[Zeno Albisser]

Committed r104546: <http://trac.webkit.org/changeset/104546>