Bug 75866 - [chromium] Add documentation to updater classes
Summary: [chromium] Add documentation to updater classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 10:39 PST by Nat Duca
Modified: 2012-01-09 17:21 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2012-01-09 11:05 PST, Nat Duca 		no flags Details | Formatted Diff | Diff
Patch (5.29 KB, patch)
2012-01-09 11:45 PST, Nat Duca 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2012-01-09 10:39:05 PST 
[chromium] Add documentation to updater classes
Comment 1 Nat Duca 2012-01-09 11:05:15 PST 
Created attachment 121692 [details]
Patch
Comment 2 David Reveman 2012-01-09 11:15:14 PST 
Comment on attachment 121692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121692&action=review

Great! Thanks for doing this.

> Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:43
> +// BitmapSkPictureCanvasLayerTextureUpdater and FrameBufferSkPictureCanvasLayerTextureUpdater

I'd prefer you changed this comment so that adding a new SkPictureCanvasLayerTextureUpdater subclass doesn't make it inaccurate or require an update to this file. How about making it a bit more general. Maybe just make it "BitmapSkPic../FramebufferSkPic.. are examples of subclasses that implement different..."
Comment 3 Nat Duca 2012-01-09 11:45:28 PST 
Created attachment 121705 [details]
Patch
Comment 4 David Reveman 2012-01-09 11:51:20 PST 
Thanks. LGTM.
Comment 5 WebKit Review Bot 2012-01-09 17:21:30 PST 
Comment on attachment 121705 [details]
Patch

Clearing flags on attachment: 121705

Committed r104522: <http://trac.webkit.org/changeset/104522>
Comment 6 WebKit Review Bot 2012-01-09 17:21:34 PST 
All reviewed patches have been landed.  Closing bug.