Bug 75863 – [Qt] REGRESSION(r100130): Clean build feature is broken.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

This bug is revealed by http://trac.webkit.org/changeset/104403 .

r104402 - everything is OK: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/builds/2048
r104403 - everything is broken: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/builds/2049

The build log said that "Feature ENABLE_CSS_FILTERS added, clean build needed!", but somehow 
all layout tests fails. After removing WebKitBuild manually, everything is OK.

[Csaba Osztrogonác]

You can easily reproduce this bug:
- update to r104402
- build
- update to r104403
- build
- run layout tests on css2.1

[Csaba Osztrogonác]

I dig a little bit and it seems HAVE_FONTCONFIG=1 is absolutely missing during the second build and it makes all tests fail, because webkit testsfonts aren't used.

[Csaba Osztrogonác]

I think the problem is in webkitdirs.pm - sub qtFeatureDefaults.
configure.pro is only called in build phase to determine if we have fontconfig or not. But feauteres.prf is called by build-webkit to set all defines passed to the build before build phase.

I'll continue digging tomorrow.

[Tor Arne Vestbø]

(In reply to comment #3)
> I think the problem is in webkitdirs.pm - sub qtFeatureDefaults.
> configure.pro is only called in build phase to determine if we have fontconfig or not. But feauteres.prf is called by build-webkit to set all defines passed to the build before build phase.
> 
> I'll continue digging tomorrow.

The configure-checks run by configure.pro cache their results in Tools/qmake/.qmake.cache, which should get loaded by features.prf on subsequent runs. I'll help you dig tomorrow.

[Csaba Osztrogonác]

The original change caused this regression:
http://trac.webkit.org/changeset/100130?format=diff&new=100130

I managed to catch what cause this bug.
Now the build phases are the following if a feature define changes:
- configure.pro is called to determine feature defines (and config tests too which generates Tools/qmake/.qmake.cache)
- clean build triggered because a feature define changes (rmtree WebKitBuild)
- make, which will be incorrect, because Tools/qmake/.qmake.cache is non-existent and HAVE_FONTCONFIG=1 macro doesn't exist, but it should be.

[Csaba Osztrogonác]

Created attachment 121820 [details]
Patch

[Tor Arne Vestbø]

Comment on attachment 121820 [details]
Patch

cool, thanks!

[Csaba Osztrogonác]

Comment on attachment 121820 [details]
Patch

Clearing flags on attachment: 121820

Committed r104548: <http://trac.webkit.org/changeset/104548>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.