Bug 75858 - Roll Chromium DEPS to last-known good revision
Summary: Roll Chromium DEPS to last-known good revision
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen Chenney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 07:54 PST by WebKit Review Bot
Modified: 2012-01-10 07:31 PST (History)
5 users (show)

See Also:

Attachments
Patch (1012 bytes, patch)
2012-01-09 07:54 PST, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
Patch (943 bytes, patch)
2012-01-09 08:25 PST, Stephen Chenney 		no flags Details | Formatted Diff | Diff
Patch (943 bytes, patch)
2012-01-09 10:03 PST, Stephen Chenney 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-01-09 07:54:14 PST 
A DEPS roll a day keeps the build break away.
Comment 1 WebKit Review Bot 2012-01-09 07:54:27 PST 
Created attachment 121673 [details]
Patch
Comment 2 Stephen Chenney 2012-01-09 08:25:19 PST 
Created attachment 121674 [details]
Patch
Comment 3 WebKit Review Bot 2012-01-09 08:37:55 PST 
Comment on attachment 121674 [details]
Patch

Attachment 121674 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11184545
Comment 4 Stephen Chenney 2012-01-09 09:06:37 PST 
An update to the dependency requires build/install-build-deps.sh on the linux machines.
Comment 5 Stephen Chenney 2012-01-09 10:03:18 PST 
Created attachment 121678 [details]
Patch
Comment 6 WebKit Review Bot 2012-01-09 11:00:24 PST 
Comment on attachment 121678 [details]
Patch

Attachment 121678 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11184586
Comment 7 Stephen Chenney 2012-01-09 11:19:20 PST 
James, any idea why your change is now causing a build failure?
Comment 8 James Robinson 2012-01-09 11:36:13 PST 
I'm not sure. The error makes sense (there is no third_party/WebKit in this configuration according to Adam) but if so then the old include path should not have worked either. There must be some magicks at work here.

To unblock the roll, feel free to revert http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/simple_webmimeregistry_impl.h?r1=116554&r2=116553&pathrev=116554 - there's still a forwarding header at Source/WebKit/chromium/public/platform/WebMimeRegistry.h
Comment 9 James Robinson 2012-01-09 11:36:35 PST 
I'll take a closer look when I get back to my desk (in a meeting now).
Comment 10 Stephen Chenney 2012-01-09 11:51:56 PST 
I can reproduce this locally, so I'll poke around and try to figure out how it was ever working, and why it doesn't now.
Comment 11 Adam Barth 2012-01-09 13:06:46 PST 
I chatted with Tony.  http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/setup_third_party.gyp?view=markup needs to be taught about Platform/chromium/public.
Comment 12 James Robinson 2012-01-09 15:41:52 PST 
http://codereview.chromium.org/9147017/
Comment 13 James Robinson 2012-01-09 19:31:14 PST 
Should be good to roll to http://src.chromium.org/viewvc/chrome?view=rev&revision=116989 or later.
Comment 14 Stephen Chenney 2012-01-10 07:31:57 PST 
The issues preventing this was fixed and a roll was done in  http://trac.webkit.org/changeset/104540